Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all kinds of env variables in query-service #578

Closed
grandwizard28 opened this issue Dec 24, 2024 · 2 comments · Fixed by #591
Closed

Enable all kinds of env variables in query-service #578

grandwizard28 opened this issue Dec 24, 2024 · 2 comments · Fixed by #591
Assignees
@TheShubhendra
Labels
chart:signoz Issue related to signoz helm chart enhancement New feature or request good first issue Good for newcomers

Comments

@grandwizard28
Copy link
Contributor

Description

Users may wish to configure env of query-service in multiple ways. Instead of treating each requirement separately, we should provide a configuration like the following:

additionalEnvs:
  env_from_secret:
    valueFrom:
      secretKeyRef:
        key: secret-1
        name: key-1
  env_from_configmap:
    valueFrom:
       configMapKeyRef:
          name: configmap-1
          key: key-1
   env_value: custom-value

This will give users the flexibility to manage env variables as they wish.
@grandwizard28 grandwizard28 added chart:signoz Issue related to signoz helm chart enhancement New feature or request good first issue Good for newcomers labels Dec 24, 2024
@TheShubhendra
Copy link
Contributor

Hi, I would like to work on this issue. Could you please assign it to me? Thanks!

@grandwizard28
Copy link
Contributor Author

Sure @TheShubhendra!

@TheShubhendra TheShubhendra mentioned this issue Jan 3, 2025
Merged
grandwizard28 pushed a commit that referenced this issue Jan 6, 2025
@TheShubhendra
Fix query service env vars handling for additionalEnvs (closes #578) (#…
ecf3b59 
…591)

This PR addresses the issue where the handling of additional environment variables (additionalEnvs) in the query service was not flexible enough.
The changes allow for both backward-compatible key-value pairs and more advanced configurations, including value references from secrets and config maps.

Changes made:
- Updated statefulset.yaml to handle different structures for additionalEnvs.
- Modified values.yaml to include examples for both types of configurations.

Closes #578.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheShubhendra TheShubhendra

Labels
chart:signoz Issue related to signoz helm chart enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix query service env vars handling for additionalEnvs (closes #578) TheShubhendra/charts
2 participants
@TheShubhendra @grandwizard28