Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom cluster name across charts #573

Closed
2 tasks done
grandwizard28 opened this issue Dec 21, 2024 · 2 comments · Fixed by #601
Closed
2 tasks done

Support custom cluster name across charts #573

grandwizard28 opened this issue Dec 21, 2024 · 2 comments · Fixed by #601
Assignees
@prashant-shahi
Labels
chart:clickhouse Issue related to clickhouse helm chart chart:signoz Issue related to signoz helm chart enhancement New feature or request

Comments

@grandwizard28
Copy link
Contributor

grandwizard28 commented Dec 21, 2024 •
edited
Loading

Description

It seems that with SigNoz/signoz-otel-collector@99de677, we have the ability to now configure a custom cluster name.

We should add support for this throughout charts

Related Issues
@grandwizard28 grandwizard28 added enhancement New feature or request chart:clickhouse Issue related to clickhouse helm chart chart:signoz Issue related to signoz helm chart labels Dec 21, 2024
@TheShubhendra
Copy link
Contributor

Hi, is any work currently being done on this? If not, I'd be happy to take it up!

@prashant-shahi prashant-shahi mentioned this issue Jan 10, 2025
Merged
@prashant-shahi
Copy link
Member

@TheShubhendra This has already been picked up:

This was referenced Jan 11, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prashant-shahi prashant-shahi

Labels
chart:clickhouse Issue related to clickhouse helm chart chart:signoz Issue related to signoz helm chart enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(schema-migrator): add --cluster-name argument from CLICKHOUSE_CLUSTER yankeguo/signoz-charts
3 participants
@prashant-shahi @TheShubhendra @grandwizard28