Skip to content

Type piracy and method overwriting in SSS and HPS #49

@GabrielKS

Description

@GabrielKS

This:
https://github.com/NREL-Sienna/StorageSystemsSimulations.jl/blob/808b04dd796e770f014ec707f81b0106da7e1831/src/core/feedforward.jl#L160
is type piracy. The exact same thing is done in HPS, so it also causes a "Method definition… overwritten" warning.

Setting aside whether we want a method this broad, is there a reason we can't put this in PSI?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions