Adapt PSB to units-aware IS/PSY API#194
Merged
Merged
Conversation
get_base_power now returns unitful MW in PSY. Internal code that needs raw Float64 for arithmetic switches to PSY._get_base_power. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Default to SU; use DU inside RTS_GMLC and the PowerSystemTableData parser. `set_X!` calls take attached-units values (`val * IS.SU` etc). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
So CI sees the same versions the local dev setup did. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
set_x! in psid_library; peak_active/reactive on Area+LoadZone in powerflowdata_data (assumed NU, see FIXME). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
The test failure is due to logged errors, not due to actual failure of unit tests. The errors look like parsing stuff, independent of the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lk/units-domain-agnostic-is4andlk/units-fold-psu.IS.SUdefault;IS.DUinsidemake_modified_RTS_GMLC_sysand thePowerSystemTableDataparser).val * IS.SU,val * IS.DU).Test plan
Pkg.test()(depends on the correspondinglk/units-fold-psuPSY branch andlk/units-domain-agnostic-is4IS branch being dev'd in)PowerFlowFileParser(PARSER_TAP_RATIO_CORRECTION_TOL), not PSB🤖 Generated with Claude Code