Skip to content

updated PrettyTables#176

Merged
jd-lara merged 4 commits into
mainfrom
hc/update_prettytables
Nov 30, 2025
Merged

updated PrettyTables#176
jd-lara merged 4 commits into
mainfrom
hc/update_prettytables

Conversation

@hannahchubin

@hannahchubin hannahchubin commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

I edited the same src/utils/print.jl file that had errors in other repos for this workflow. The PrettyTables kwarg header is now called column_labels. All tests are passing. Waiting to see what other backwards compatibility changes need to be made, other than in Project.toml, using Pretty Tables = "2.1, 3.1".

@hannahchubin hannahchubin requested a review from jd-lara November 25, 2025 20:02
@hannahchubin

Copy link
Copy Markdown
Contributor Author

@jd-lara This PR is ready for review. I was wondering though, since only one function needed to be removed from print.jl and added to the different print.jl versions, would it make more sense to just keep the one print.jl and add a conditional along the lines of: if PT version =2, header = header and if PT version = 3, column_labels = column_labels? Seems overkill to add two new files for just one function with one kwarg difference

@codecov

codecov Bot commented Nov 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.46%. Comparing base (f0df95e) to head (e5b9ee4).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/print_pt_v2.jl 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   92.50%   92.46%   -0.05%     
==========================================
  Files          16       18       +2     
  Lines        4352     4354       +2     
==========================================
  Hits         4026     4026              
- Misses        326      328       +2     
Flag Coverage Δ
unittests 92.46% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/utils/print.jl 33.33% <ø> (-13.61%) ⬇️
src/utils/print_pt_v3.jl 100.00% <100.00%> (ø)
src/utils/print_pt_v2.jl 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hannahchubin and others added 2 commits November 26, 2025 13:51
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jd-lara jd-lara merged commit 0f83dcf into main Nov 30, 2025
5 of 7 checks passed
@jd-lara jd-lara deleted the hc/update_prettytables branch December 16, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants