address issue 9#133
Open
luke-kiernan wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #9 by ensuring renewables that lack active_power_limits can still build quadratic-cost objectives by bridging InfrastructureOptimizationModels.get_active_power_limits for PowerSystems.RenewableGen.
Changes:
- Add an
IOM.get_active_power_limits(::PSY.RenewableGen)overload that returns(min=0.0, max=get_max_active_power(...)). - Add a regression test ensuring a
RenewableDispatchwith a quadratic cost curve constructs a quadratic objective and that the new limits bridge returns the expected tuple. - Update the
PowerSystemscompat version to5.10.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/test_device_renewable_generation_constructors.jl |
Adds a regression test for quadratic renewable cost objective construction and the renewable-specific active power limits bridge. |
src/common_models/market_bid_plumbing.jl |
Implements the renewable-specific IOM.get_active_power_limits fallback using max_active_power. |
Project.toml |
Bumps PowerSystems compat to 5.10. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Not sure if this is related but I think we just recently flipped the sign to positive in PSI now that curtailment costs have been added. |
|
Performance Results
|
jd-lara
reviewed
Jun 8, 2026
jd-lara
left a comment
jd-lara
left a comment
Member
There was a problem hiding this comment.
We just did a merge to fix this in PSI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #9.
A separate question came up while writing this: PSI and POM have opposite objective function signs for
RenewableDispatch. First, is that a bug in POM? And second, if so, how the heck did that happen and not get caught by our test cases...edit: false alarm, opposite signs isn't a bug in POM. Thanks Anthony for setting me straight: the git blame confirms that PSI only changed to using a positive sign 3 weeks ago.