Remove model from being interpolated into warning strings#124
Merged
Conversation
jd-lara
approved these changes
May 29, 2026
Member
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # src/operation/decision_model.jl # src/operation/emulation_model.jl
Contributor
Merge conflicts in |
jd-lara
approved these changes
Jun 8, 2026
|
Performance Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First one is a bug.
The others: interpolating a
built!model is very expensive. I was runningPOM.solve!(model)and wondering why there was a 5 minute delay and so much stuff being printed to the screen. I don't know if removing is okay, or if there is a better identifier we can use here.