-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support storybook composition #17
Comments
Hi @RobbyRabbitman! For sure, tagBadges addons defined on the composed Storybooks would not load (https://storybook.js.org/docs/sharing/storybook-composition says somewhere that composed addons do not get loaded). I don't know if addons defined on the Storybook instance that loads external stories run everywhere. I also don't know if the sidebar entries go through the same code, and that's something I'd need to try out. If you have a public repo set up with composition already configured, feel free to share it. It'll save me some time to repro and test. |
Thanks for the reply, I will try it out in the next couple of days but i cannot share it 😄 |
Thanks! I'm assigning this to you so I know I'm waiting to hear back from you :) |
Observation: the badges are shown when the config is also set on the host storybook instance - however I wonder why the output is different. Left=host and Right=Child. Both instances use the framework export const createHdiComponentTagConfig = (
...config: TagBadgeParameters
): {
[STORYBOOK_ADDON_TAG_BADGES_CONFIG_KEY]: TagBadgeParameters;
} => ({
[STORYBOOK_ADDON_TAG_BADGES_CONFIG_KEY]: [
{
tags: ['preview'] satisfies HdiComponentTag[],
badge: {
text: 'Preview',
},
},
...config,
...defaultConfig,
],
}); |
Could you please check lock files for both projects to check they use the
same version? Just to eliminate the matter of a recent update I did that
changes display conditions for stories badges.
|
Hi, thanks for the great addon!
I wonder if displaying the badges in a storybook composition setup is possible - probably not because the host just queries the metadata of the components and stories of the other storybook instances right?
The text was updated successfully, but these errors were encountered: