Merge pull request #367 from jaykayrey/main

lizkenyon · web-flow · commit 39c63a23d5a9 · 2025-01-07T09:33:05.000-06:00
Fixed bug that doesn't allow for uppercase letters in redirect_uri
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## Unreleased
 - [#393](https://github.com/Shopify/shopify-api-php/pull/393) [Minor] Add support for 2025-01 API version REST resources
+- [#367](https://github.com/Shopify/shopify-api-php/pull/367) [Patch] Allow uppercase characters in redirect URI
 
 ## v5.8.1 - 2024-11-13
 - [#387](https://github.com/Shopify/shopify-api-php/pull/387) [Patch] Fix GraphQL request to properly encode query string
diff --git a/src/Auth/OAuth.php b/src/Auth/OAuth.php
@@ -63,7 +63,7 @@ public static function begin(
             throw new InvalidArgumentException("Invalid shop domain: $shop");
         }
 
-        $redirectPath = trim(strtolower($redirectPath));
+        $redirectPath = trim($redirectPath);
         $redirectPath = ($redirectPath[0] == '/') ? $redirectPath : '/' . $redirectPath;
 
         $state = Uuid::uuid4()->toString();

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public static function begin(`
`63`	`63`	`throw new InvalidArgumentException("Invalid shop domain: $shop");`
`64`	`64`	`}`
`65`	`65`
`66`		`- $redirectPath = trim(strtolower($redirectPath));`
	`66`	`+ $redirectPath = trim($redirectPath);`
`67`	`67`	`$redirectPath = ($redirectPath[0] == '/') ? $redirectPath : '/' . $redirectPath;`
`68`	`68`
`69`	`69`	`$state = Uuid::uuid4()->toString();`