Skip to content

Commit dc32e8c

Browse files
mateussam-b-rose
andauthored
[stylelint-polaris] Add postcss-scss and stylelint-scss as dependencies (#11658)
### WHY are these changes introduced? Currently, consumers of `stylelint-polaris`, which leverages `postcss-scss` and `stylelint-scss` internally, are required to install these packages as `devDependencies`. This is the case even if they are not directly utilized within their applications. A more streamlined approach would be to incorporate these packages directly within the `stylelint-polaris` package as dependencies. This adjustment would enable consumers to eliminate these packages from their `devDependencies`, thereby simplifying their dependency management and making the dependencies more transparent. ### How to 🎩 Testing snapshot Shopify/web#119693 ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sam Rose <[email protected]>
1 parent d9b71a2 commit dc32e8c

File tree

3 files changed

+30
-0
lines changed

3 files changed

+30
-0
lines changed

.changeset/perfect-kings-relax.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/stylelint-polaris': minor
3+
---
4+
5+
Added postcss-scss and stylelint-scss as dependencies

stylelint-polaris/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535
"clean": "rm -rf .turbo node_modules dist"
3636
},
3737
"dependencies": {
38+
"stylelint-scss": "^4.4.0",
39+
"postcss-scss": "^4.0.9",
3840
"postcss-value-parser": "^4.2.0",
3941
"postcss-media-query-parser": "^0.2.3",
4042
"@shopify/polaris-tokens": "^8.8.0"

yarn.lock

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18184,6 +18184,11 @@ postcss-scss@^4.0.2, postcss-scss@^4.0.4:
1818418184
resolved "https://registry.yarnpkg.com/postcss-scss/-/postcss-scss-4.0.4.tgz#aa8f60e19ee18259bc193db9e4b96edfce3f3b1f"
1818518185
integrity sha512-aBBbVyzA8b3hUL0MGrpydxxXKXFZc5Eqva0Q3V9qsBOLEMsjb6w49WfpsoWzpEgcqJGW4t7Rio8WXVU9Gd8vWg==
1818618186

18187+
postcss-scss@^4.0.9:
18188+
version "4.0.9"
18189+
resolved "https://registry.yarnpkg.com/postcss-scss/-/postcss-scss-4.0.9.tgz#a03c773cd4c9623cb04ce142a52afcec74806685"
18190+
integrity sha512-AjKOeiwAitL/MXxQW2DliT28EKukvvbEWx3LBmJIRN8KfBGZbRTxNYW0kSqi1COiTZ57nZ9NW06S6ux//N1c9A==
18191+
1818718192
postcss-selector-parser@^6.0.10, postcss-selector-parser@^6.0.2, postcss-selector-parser@^6.0.4, postcss-selector-parser@^6.0.5, postcss-selector-parser@^6.0.6, postcss-selector-parser@^6.0.9:
1818818193
version "6.0.10"
1818918194
resolved "https://registry.yarnpkg.com/postcss-selector-parser/-/postcss-selector-parser-6.0.10.tgz#79b61e2c0d1bfc2602d549e11d0876256f8df88d"
@@ -18192,6 +18197,14 @@ postcss-selector-parser@^6.0.10, postcss-selector-parser@^6.0.2, postcss-selecto
1819218197
cssesc "^3.0.0"
1819318198
util-deprecate "^1.0.2"
1819418199

18200+
postcss-selector-parser@^6.0.11:
18201+
version "6.0.15"
18202+
resolved "https://registry.yarnpkg.com/postcss-selector-parser/-/postcss-selector-parser-6.0.15.tgz#11cc2b21eebc0b99ea374ffb9887174855a01535"
18203+
integrity sha512-rEYkQOMUCEMhsKbK66tbEU9QVIxbhN18YiniAwA7XQYTVBqrBy+P2p5JcdqsHgKM2zWylp8d7J6eszocfds5Sw==
18204+
dependencies:
18205+
cssesc "^3.0.0"
18206+
util-deprecate "^1.0.2"
18207+
1819518208
postcss-sorting@^7.0.1:
1819618209
version "7.0.1"
1819718210
resolved "https://registry.yarnpkg.com/postcss-sorting/-/postcss-sorting-7.0.1.tgz#923b5268451cf2d93ebf8835e17a6537757049a5"
@@ -21017,6 +21030,16 @@ stylelint-scss@^4.0.0:
2101721030
postcss-selector-parser "^6.0.6"
2101821031
postcss-value-parser "^4.1.0"
2101921032

21033+
stylelint-scss@^4.4.0:
21034+
version "4.7.0"
21035+
resolved "https://registry.yarnpkg.com/stylelint-scss/-/stylelint-scss-4.7.0.tgz#f986bf8c5a4b93eae2b67d3a3562eef822657908"
21036+
integrity sha512-TSUgIeS0H3jqDZnby1UO1Qv3poi1N8wUYIJY6D1tuUq2MN3lwp/rITVo0wD+1SWTmRm0tNmGO0b7nKInnqF6Hg==
21037+
dependencies:
21038+
postcss-media-query-parser "^0.2.3"
21039+
postcss-resolve-nested-selector "^0.1.1"
21040+
postcss-selector-parser "^6.0.11"
21041+
postcss-value-parser "^4.2.0"
21042+
2102021043
stylelint@^14.15.0:
2102121044
version "14.15.0"
2102221045
resolved "https://registry.yarnpkg.com/stylelint/-/stylelint-14.15.0.tgz#4df55078e734869f81f6b85bbec2d56a4b478ece"

0 commit comments

Comments
 (0)