Skip to content

Commit a50b17d

Browse files
authored
Fix bugs on polaris website (#11556)
### WHAT is this pull request doing? - [x] Fixes missing icons on `/design` pages - [x] Removes "Internal only" components landing page from search and keeps it in the sidebar - [x] Fixes Legacy Filters image in search results
1 parent 60da1e3 commit a50b17d

File tree

6 files changed

+12
-7
lines changed

6 files changed

+12
-7
lines changed

polaris.shopify.com/content/components/deprecated/legacy-filters.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
title: Legacy filters
33
shortDescription: Legacy version of the Filters component. Used to filter the items of a list or table.
4-
category: Selection and input
4+
category: Deprecated
55
keywords:
66
- filters
77
- filtering

polaris.shopify.com/content/design/colors/palettes-and-roles.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ keywords:
88
- color use
99
- black and white
1010
- grayscale
11-
icon: ColorsIcon
11+
icon: ColorIcon
1212
---
1313

1414
# Color → {frontmatter.title}

polaris.shopify.com/content/design/layout/spacial-organization.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
title: Spacial organization
33
order: 1
4-
icon: BuyButtonButtonLayoutIcon
4+
icon: LayoutBuyButtonHorizontalIcon
55
keywords:
66
- layout
77
- layout components

polaris.shopify.com/content/design/typography/font-and-typescale.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ keywords:
66
- type styles
77
- font sizes
88
- fonts
9-
icon: TextAlignmentLeftIcon
9+
icon: TextAlignLeftIcon
1010
hideChildren: true
1111
order: 1
1212
---

polaris.shopify.com/content/design/typography/using-type.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ keywords:
66
- type styles
77
- font sizes
88
- fonts
9-
icon: TypeIcon
9+
icon: TextFontIcon
1010
hideChildren: true
1111
order: 2
1212
---

polaris.shopify.com/pages/api/search/v0/index.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ import {slugify, stripMarkdownLinks} from '../../../../src/utils/various';
1919
import pages from '../../../../.cache/site';
2020

2121
type IndexablePages = {
22-
[K in keyof typeof pages as (typeof pages)[K]['frontMatter'] extends {
22+
[K in keyof typeof pages as typeof pages[K]['frontMatter'] extends {
2323
noIndex: true;
2424
}
2525
? never
26-
: K]: (typeof pages)[K];
26+
: K]: typeof pages[K];
2727
};
2828

2929
const searchablePages = Object.fromEntries(
@@ -70,12 +70,17 @@ const getSearchResults = (query?: string) => {
7070
title,
7171
description = '',
7272
category = '',
73+
internalOnly,
7374
} = searchablePages[slug].frontMatter as FrontMatter;
7475

7576
const url = category
7677
? `/components/${slugify(category)}/${slugify(title)}`
7778
: `/components/${slugify(title)}`;
7879

80+
if (internalOnly) {
81+
return;
82+
}
83+
7984
results.push({
8085
id: slugify(`components ${title}`),
8186
category: 'components',

0 commit comments

Comments
 (0)