Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Add override for unconfined apparmor profile ✨ #489

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

Ser87ch
Copy link
Contributor

@Ser87ch Ser87ch commented Oct 8, 2022

Description
  • Adds override for the unconfined AppArmor profile.
  • Adds AppArmorBadValue for an unsupported AppArmor profile value.
  • Adds Override Errors section to the apparmor documentation.

Fixes #442

Type of change
  • [ X] New feature ✨
  • [ X] This change requires a documentation update 📖
How Has This Been Tested?
  • Automated tests.
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

genevieveluyt
genevieveluyt previously approved these changes Oct 11, 2022
Copy link
Contributor

@genevieveluyt genevieveluyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 looks good! Good idea separating unconfined (disabled) vs bad value (configuration error) 👍 Thanks!

@genevieveluyt genevieveluyt merged commit fbffa4a into Shopify:main Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AppArmor profile unconfined
2 participants