Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

How to override errors for a daemonset? #325

Closed
1 task
dmitry-irtegov opened this issue Feb 10, 2021 · 4 comments
Closed
1 task

How to override errors for a daemonset? #325

dmitry-irtegov opened this issue Feb 10, 2021 · 4 comments

Comments

@dmitry-irtegov
Copy link

dmitry-irtegov commented Feb 10, 2021

ISSUE TYPE
  • [+] Feature Idea

FEATURE IDEA

  • If the maintainers agree with the feature as described here, I intend to submit a Pull Request myself.1

Proposal:

I want to add error override labels for a CNI plugin.

Obviously, it must run as root, have host network and NET_ADMIN capability.

The plugin itself is a daemon set, so it has no fixed pod name, so I cannot override errors on the pod level (or, at least, do not understand how).

The pod has several containers, so adding these labels at container level is tedious.

I hope for CNI plugins it will be fixed with #275 , but there might be other daemonsets which needs auditing (logging, etc).

1 This is the quickest way to get a new feature! We reserve the right to close feature requests, even ones we like, if the proposer does not intend to contribute to the feature and it doesn't fit in our current roadmap.

@ghost
Copy link

ghost commented Feb 10, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@genevieveluyt
Copy link
Contributor

Hey dmitry-irtegov, here is an example setting a pod override for a deployment: https://github.com/Shopify/kubeaudit/blob/master/docs/auditors/asat.md#override-errors

It should be similar for a daemonset (the pod override applies to all pods created by a resource). Please report back if it doesn't work for you!

@dmitry-irtegov
Copy link
Author

Thanks, I will try this.

@rxbchen
Copy link
Contributor

rxbchen commented Apr 19, 2021

closing this for now, feel free to re-open this if it is an issue!

@rxbchen rxbchen closed this as completed Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants