More coverage

Author: atesgoral

lib/json_rpc_handler.rb

@@ -34,9 +34,18 @@ def handle(request, &find_method)
       responses = request.map { |req| process_request(req, &find_method) }.compact
       # And empty array yields nil
       responses if responses.any?
-    else
+    elsif request.is_a? Hash
       # Handle single request
       process_request(request, &find_method)
+    else
+      error_response(
+        id: nil,
+        error: {
+          code: ErrorCode::InvalidRequest,
+          message: 'Invalid Request',
+          data: 'Request must be an array or a hash',
+        },
+      )
     end
   end
 
@@ -108,8 +117,6 @@ def process_request(request, &find_method)
 
   def validate_request(request)
     error = case
-    when !request.is_a?(Hash)
-      'Request must be an object'
     when !valid_version?(request[:jsonrpc])
       'JSON-RPC version must be 2.0'
     when !valid_id?(request[:id])

test/json_rpc_handler_test.rb

@@ -27,6 +27,12 @@
     # jsonrpc
     #   A String specifying the version of the JSON-RPC protocol. MUST be exactly "2.0".
 
+    it "returns an error when the request is not an array or a hash" do
+      handle(true)
+
+      assert_rpc_error(expected_error: { code: -32600, message: "Invalid Request", data: "Request must be an array or a hash" })
+    end
+
     it "returns a result when jsonrpc is 2.0" do
       register("add") do |params|
         params[:a] + params[:b]
@@ -252,6 +258,12 @@
       assert_rpc_error(expected_error: { code: -32601, message: "Method not found", data: "add" })
     end
 
+    it "returns nil when the method does not exist and the id is nil" do
+      handle({ jsonrpc: "2.0", method: "add", params: { a: 1, b: 2 } })
+
+      assert_nil @response
+    end
+
     it "returns an error with the code set to -32602 when the method parameters are invalid" do
       handle({ jsonrpc: "2.0", id: 1, method: "set_active", params: true })