structured_data filter throws Liquid error when first media isn't an image

[chrisberthe]

The structured_data filter throws a Liquid error: invalid url input error when a product has the following conditions:

1. A single variant
2. The first media isn't an image, i.e. a video or 3D model

Usage:

<script type="application/ld+json">
  {{ product | structured_data }}
</script>

There may be other product setup conditions that affect this. This happens in Dawn as well.

cc @ludoboludo @tyleralsbury (👋🏻)

[tyleralsbury]

Thanks for this, @bertiful . I'll bring it to the team and we'll see what we can do.

[graham-shopify]

Hey team, TMS here. I see that this issue is still occurring after the PR above. I have been able to replicate on my test store when adding a video as the first media item. I'm not sure if a recent change undid the fix from above, but as of Jan 26, 2025 the issue is occurring again.

[tyleralsbury]

Hey team, TMS here. I see that this issue is still occurring after the PR above. I have been able to replicate on my test store when adding a video as the first media item. I'm not sure if a recent change undid the fix from above, but as of Jan 26, 2025 the issue is occurring again.

I haven't had the opportunity to merge that PR. Actually... lemme reach out to someone who might be able to pick it up.

[albchu]

Hey Graham, Tyler reached out to me to take this on. I will be giving Tyler's PR a closer look this week and will aim to get this wrapped and out the door. Will keep yall posted!

[albchu]

Hey quick update here! I have refreshed Tyler's fix PR and have now queued it up for merging into storefront-renderer. Hopefully this will be live in the next few hours.

[tyleralsbury]

Thank you so much, Albert. :)