Replies: 2 comments
-
|
/cc @KaichenWang would be great to have this in before v8 is released so that we don't have to wait another 3-4 months for the next major version. Let's have v8 all cleaned up and auto-formatted before release? |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Hey @KaichenWang any updates on this? This is really important change for me because it will allow me to keep my Dawn fork in sync with the upstream. Thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi,
I'm trying to setup Prettier so that the formatting of Liquid and JS and CSS files is consistent with the current formatting within the repo here.
This is my
.prettierrc:{ "printWidth": 120, "singleQuote": true, "embeddedSingleQuote": true, "htmlWhitespaceSensitivity": "ignore", "indentSchema": true }This is clearly not working because the code style is not consistent.
I saw there has been a great progress done to unify the Prettier code style, especially in Liquid files: #2115 and #2126
However, JS and CSS files seem to be manually formatted?
Any chance the Shopify team could create a Prettier config and format all JS and CSS files so that we can end discussion on code formatting and make sure we get the benefits of automatic code formatting?
For example: I want to use automatic code formatting so that I don't have to think about it. I write some code as fast as I can and let Prettier format it for me nicely if I didn't do a great job, which happens often. Unfortunately, in Dawn project, Prettier formats the whole file leading into a lot of irrelevant changes. I'd love to be able to avoid this.
Beta Was this translation helpful? Give feedback.
All reactions