Skip to content

Commit 7def6b3

Browse files
committed
use GetBoolValueOnEntry for cloth and stinky
1 parent cedf485 commit 7def6b3

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

HollowKnightComponent.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -872,11 +872,12 @@ private SplitterAction CheckSplit(SplitName split, string nextScene, string curr
872872
case SplitName.HappyCouplePlayerDataEvent: shouldSplit = mem.PlayerData<bool>(Offset.nailsmithConvoArt); break;
873873

874874
case SplitName.WhiteDefenderStatueUnlocked:
875+
bool convo = store.GetBoolValueOnEntry(Offset.dungDefenderAwakeConvo);
875876
shouldSplit =
876877
currScene == "Waterways_15"
877878
&& mem.PlayerData<bool>(Offset.dungDefenderAwoken)
878879
&& mem.PlayerData<bool>(Offset.dungDefenderLeft)
879-
&& store.DungDefenderAwakeConvoOnEntry
880+
&& convo
880881
&& (mem.GetCameraTarget().X < 29.5);
881882
break;
882883

@@ -1387,7 +1388,8 @@ private SplitterAction CheckSplit(SplitName split, string nextScene, string curr
13871388
shouldSplit = store.CheckIncremented(Offset.dreamOrbs) && currScene == "Cliffs_05";
13881389
break;
13891390
case SplitName.OnObtainGhostCloth:
1390-
shouldSplit = store.CheckIncremented(Offset.dreamOrbs) && currScene == "Fungus3_23" && store.TraitorLordDeadOnEntry;
1391+
bool traitorLordBeenDead = store.GetBoolValueOnEntry(Offset.killedTraitorLord);
1392+
shouldSplit = store.CheckIncremented(Offset.dreamOrbs) && currScene == "Fungus3_23" && traitorLordBeenDead;
13911393
break;
13921394
case SplitName.OnObtainGhostVespa:
13931395
// UsesSceneTransitionRoutine is true on patches where Hive Knight exists

HollowKnightStoredData.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ public void Update(T val) {
2323
private ConcurrentDictionary<Offset, Tracked<bool>> pdBools = new ConcurrentDictionary<Offset, Tracked<bool>>();
2424
private ConcurrentDictionary<Offset, int> pdEntryInts = new ConcurrentDictionary<Offset, int>();
2525
private ConcurrentDictionary<Offset, bool> pdEntryBools = new ConcurrentDictionary<Offset, bool>();
26-
public bool TraitorLordDeadOnEntry { get; private set; } = false;
27-
public bool DungDefenderAwakeConvoOnEntry { get; private set; } = false;
2826
public int HealthBeforeFocus { get; private set; } = 0;
2927
public int MPChargeBeforeFocus { get; private set; } = 0;
3028
/// <summary>
@@ -46,8 +44,8 @@ public void Update(T val) {
4644
public void Reset() {
4745
pdInts.Clear();
4846
pdBools.Clear();
49-
TraitorLordDeadOnEntry = false;
50-
DungDefenderAwakeConvoOnEntry = false;
47+
pdEntryInts.Clear();
48+
pdEntryBools.Clear();
5149
HealthBeforeFocus = 0;
5250
MPChargeBeforeFocus = 0;
5351
SplitThisTransition = false;
@@ -205,8 +203,6 @@ public void Update() {
205203
|| mem.SceneName() != mem.NextSceneName()) {
206204
// In transition
207205
PrevScene = mem.SceneName();
208-
TraitorLordDeadOnEntry = mem.PlayerData<bool>(Offset.killedTraitorLord);
209-
DungDefenderAwakeConvoOnEntry = mem.PlayerData<bool>(Offset.dungDefenderAwakeConvo);
210206
pdEntryInts.Clear();
211207
pdEntryBools.Clear();
212208
} else {

0 commit comments

Comments
 (0)