Incomplete ArrayTypes/DictionaryTypes in TypeScriptGenerator

[ItsClemi]

Hi,

we're currently running into an issue where servicestack's typescript code gen doesn't translate the IList<T> type of our response model. When using the underlying ICollection<T> type, the correct output gets emitted.

As the dart-gen worked fine, I've taken a look at the source-code and found that the fields ArrayTypes and DictionaryTypes of the following generators mismatch with the dart gen:

• TypeScriptGenerator
• SwiftGenerator
• JavaGenerator
• KotlinGenerator
• PythonGenerator

For now I've fixed the issue by manually adding the missing types to the TypeScriptGenerator via:

        TypeScriptGenerator.ArrayTypes.AddDistinctRange(new[] {
            "IList`1", 
            "ConcurrentQueue`1", 
            "ConcurrentStack`1", 
            "ArrayList",
        });

        TypeScriptGenerator.DictionaryTypes.AddDistinctRange(new[] {
            "ConcurrentDictionary`2",
            "SortedList`2",
            "SortedList",
            "Hashtable",
        });

But shouldn't the values of ArrayTypes and DictionaryTypes match in each of these generators?

Thanks! 🙂

[mythz]

Using Interfaces or objects in DTOs is both highly discouraged and not supported in Add ServiceStack Reference languages.

Use known concrete collections like List<T> instead of IList<T> which should never be used in DTOs.