Skip to content

[Enhancement] Core changes to add support for custom proxy models #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vipul-mittal merged 11 commits into from
Jan 13, 2026
Merged

[Enhancement] Core changes to add support for custom proxy models #101

vipul-mittal merged 11 commits into from
Jan 13, 2026

Conversation

@Sidharthenee333
Copy link
Collaborator

@Sidharthenee333 Sidharthenee333 commented Jan 7, 2026 •
edited
Loading

Summary

This PR adds support to run custom gemini and claude models using proxy urls

Explain the features implemented:

  • A new backend type which is "proxy" has been introduced
  • In model configuration if client type is specified then that will be used otherwise the model type will be used for creating the required client
  • In custom models, classes have been added to run claude and gemini models using proxy urls

Performance impact (if any):

  • N/A - New feature with no impact on existing functionality.

How to Test the feature

  1. Run the glaive_code_assistant task using proxy models where client type and backend type are mentioned
  2. Run the glaive_code_assistant task using any openai or vertexai models where client type is not mentioned

Screenshots (if applicable)

NA

Checklist

  • Lint fixes and unit testing done
  • End to end task testing
  • Documentation updated

@Sidharthenee333 Sidharthenee333 requested a review from a team as a code owner January 7, 2026 12:58
@Sidharthenee333 Sidharthenee333 added the enhancement New feature or request label Jan 7, 2026
github-code-quality[bot]
github-code-quality bot found potential problems Jan 7, 2026
View reviewed changes
bidyapati-p
bidyapati-p reviewed Jan 8, 2026
View reviewed changes
bidyapati-p
bidyapati-p reviewed Jan 8, 2026
View reviewed changes
psriramsnc
psriramsnc reviewed Jan 8, 2026
View reviewed changes
github-code-quality[bot]
github-code-quality bot found potential problems Jan 8, 2026
View reviewed changes
psriramsnc
psriramsnc reviewed Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@psriramsnc psriramsnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases and validation checks to the new client_type param introduced.

psriramsnc
psriramsnc previously approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@psriramsnc psriramsnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

bidyapati-p
bidyapati-p reviewed Jan 12, 2026
View reviewed changes
@bidyapati-p
Copy link
Collaborator

bidyapati-p commented Jan 12, 2026

@psriramsnc Can you please approve again? Small doc changes updated in last commit.

@bidyapati-p bidyapati-p requested a review from a team January 12, 2026 17:34
@vipul-mittal vipul-mittal merged commit 510382f into main Jan 13, 2026
3 checks passed
@vipul-mittal vipul-mittal deleted the scratch/core_changes_for_proxy_support branch January 13, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psriramsnc psriramsnc psriramsnc approved these changes

@bidyapati-p bidyapati-p bidyapati-p approved these changes

+1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sidharthenee333 @bidyapati-p @psriramsnc @vipul-mittal