Skip to content

Commit ca208a9

Browse files
committed
Removed 'isRoot' field from Sample; added in experiment accession for every Sample in BatchMetadataInjection; Added in null parents for samples.
Former-commit-id: c742f59
1 parent e3f1c7a commit ca208a9

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

seqware-common/src/main/java/net/sourceforge/seqware/common/metadata/MetadataWS.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -296,12 +296,14 @@ public ReturnValue addSample(Integer experimentAccession, Integer parentSampleAc
296296
Experiment e = ll.findExperiment("/" + experimentAccession.toString());
297297
s.setExperiment(e);
298298
}
299+
Set<Sample> parents = new HashSet<Sample>();
299300
if (parentSampleAccession != 0) {
300301
Sample parentSample = ll.findSample("/"+parentSampleAccession);
301-
Set<Sample> parents = new HashSet<Sample>();
302302
parents.add(parentSample);
303-
s.setParents(parents);
303+
} else{
304+
parents.add(null);
304305
}
306+
s.setParents(parents);
305307
s.setOrganism(o);
306308
s.setTitle(title);
307309
s.setName(title);

seqware-common/src/main/java/net/sourceforge/seqware/common/model/Sample.java

-8
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ public int compare(Sample t, Sample t1) {
8181
private Set<SampleLink> sampleLinks = new TreeSet<SampleLink>();
8282
// non-persisted field to store organism_id
8383
private Integer organismId;
84-
private boolean isRoot;
8584

8685
/**
8786
* <p>Constructor for Sample.</p>
@@ -928,13 +927,6 @@ public void setSampleLinks(Set<SampleLink> sampleLinks) {
928927
this.sampleLinks = sampleLinks;
929928
}
930929

931-
public boolean isIsRoot() {
932-
return isRoot;
933-
}
934-
935-
public void setIsRoot(boolean isRoot) {
936-
this.isRoot = isRoot;
937-
}
938930

939931
/**
940932
* {@inheritDoc}

seqware-pipeline/src/main/java/net/sourceforge/seqware/pipeline/plugins/BatchMetadataInjection.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -187,11 +187,11 @@ private ReturnValue inject(RunInfo run) throws Exception {
187187

188188
Log.debug("lane: " + laneAccession + " parent sample: " + parentSampleAcc);
189189

190-
int tissueTypeSampleAcc = retrieveTissueTypeSampleAccession(parentSampleAcc, barcode);
190+
int tissueTypeSampleAcc = retrieveTissueTypeSampleAccession(parentSampleAcc, barcode, experimentAccession);
191191

192192
Log.debug("tissue type sample: " + tissueTypeSampleAcc);
193193

194-
int librarySampleNameAcc = createLibrarySample(barcode, tissueTypeSampleAcc);
194+
int librarySampleNameAcc = createLibrarySample(barcode, tissueTypeSampleAcc, experimentAccession);
195195

196196
int barcodeAcc = createIUS(barcode, laneAccession, librarySampleNameAcc);
197197

@@ -200,11 +200,11 @@ private ReturnValue inject(RunInfo run) throws Exception {
200200
return ret;
201201
}
202202

203-
private int createLibrarySample(SampleInfo sample, int tissueTypeSampleAcc) throws Exception {
203+
private int createLibrarySample(SampleInfo sample, int tissueTypeSampleAcc, int experimentAccession) throws Exception {
204204

205205
//get the library sample
206206
int librarySampleNameAcc = createSample(sample.getName(), sample.getSampleDescription(),
207-
0, tissueTypeSampleAcc, sample.getOrganismId(), true);
207+
experimentAccession, tissueTypeSampleAcc, sample.getOrganismId(), true);
208208

209209
List<Sample> children = metadata.getChildSamplesFrom(tissueTypeSampleAcc);
210210
for (Sample s : children) {
@@ -223,7 +223,7 @@ private int createLibrarySample(SampleInfo sample, int tissueTypeSampleAcc) thro
223223
return librarySampleNameAcc;
224224
}
225225

226-
private int retrieveTissueTypeSampleAccession(Integer parentSampleAcc, SampleInfo barcode) throws Exception {
226+
private int retrieveTissueTypeSampleAccession(Integer parentSampleAcc, SampleInfo barcode, int experimentAccession) throws Exception {
227227
//get the tissue type sample if it exists, otherwise create it
228228
int tissueTypeSampleAcc = 0;
229229
String name = barcode.getParentSample() + "_" +barcode.getTissueOrigin()+"_"+ barcode.getTissueType();
@@ -236,7 +236,7 @@ private int retrieveTissueTypeSampleAccession(Integer parentSampleAcc, SampleInf
236236
}
237237
}
238238
if (tissueTypeSampleAcc == 0) {
239-
tissueTypeSampleAcc = createSample(name, "", 0,
239+
tissueTypeSampleAcc = createSample(name, "", experimentAccession,
240240
parentSampleAcc, barcode.getOrganismId(), false);
241241
}
242242
names.put(tissueTypeSampleAcc, name);

0 commit comments

Comments
 (0)