Skip to content

Conversation

@vaishnavyogesh
Copy link

It was painful to add a processor to the bottom of the stack since we need to first pop all the processors then push it and popped processors back leading to O(N).

I believe it's just better to provide support for adding a processor to the bottom of the stack in just O(1).

Usecase: Let's say we have a processor which masks sensitive fields from the log record and it just makes sense to mask the details at the end after going through all previous processors, if we don't do it this way then the latter processors could add sensitive fields which won't be masked in that case.

Let me know any suggestions for improvements.

@Seldaek Also I believe we should dockerize the development environment, I'd like to work on the same too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant