Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mise: manifest updated to more portable config #6453

Merged
merged 10 commits into from
Jan 17, 2025
Merged

mise: manifest updated to more portable config #6453

merged 10 commits into from
Jan 17, 2025

Conversation

ev-dev
Copy link
Contributor

@ev-dev ev-dev commented Jan 13, 2025 •
edited
Loading

Included manifest changes suggested by @chawyehsu in PR comment which sets the internal mise configurable env var MISE_DATA_DIR to a directory that scoop persists

Relates to #6374

  • removed install/uninstall scripts
  • set env var MISE_DATA_DIR to a directory inside scoop and persist it
  • add the directory mise places its own shims to the Path env var
  • set env var MISE_GLOBAL_CONFIG_FILE to file inside app install dir and persist it
  • added pre_install script to check mise config.toml exists or is created as a file
  • added note about configuring specific shells with link to mise docs

@ev-dev
mise: More portable manifest setup using a persist dir and mise inter…
ce6b941 
…nal env vars

Included manifest changes suggested by @chawyehsu in PR ScoopInstaller#6374 which sets the internal mise configurable env var MISE_DATA_DIR to a directory that scoop persists
@ev-dev ev-dev mentioned this pull request Jan 13, 2025
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

mise

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@ev-dev ev-dev marked this pull request as draft January 13, 2025 17:10
@ev-dev

This comment was marked as resolved.

Sign in to view
@ev-dev ev-dev marked this pull request as ready for review January 13, 2025 17:33
chawyehsu
chawyehsu requested changes Jan 14, 2025
View reviewed changes
bucket/mise.json Outdated Show resolved Hide resolved
bucket/mise.json Outdated Show resolved Hide resolved
@ev-dev ev-dev requested a review from chawyehsu January 15, 2025 22:14
stevehipwell
stevehipwell approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Contributor

@chawyehsu is there a reason you didn't merge this after approving it?

@chawyehsu chawyehsu merged commit 30ea341 into ScoopInstaller:master Jan 17, 2025
2 checks passed
@chawyehsu
Copy link
Member

@chawyehsu is there a reason you didn't merge this after approving it?

I just forgot to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehipwell stevehipwell stevehipwell approved these changes

@chawyehsu chawyehsu chawyehsu approved these changes

Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ev-dev @stevehipwell @chawyehsu