Skip to content

Commit 35a3dc3

Browse files
Mark broken and fail downstream
1 parent fa0f129 commit 35a3dc3

File tree

3 files changed

+7
-15
lines changed

3 files changed

+7
-15
lines changed

.github/workflows/Downstream.yml

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,11 @@ jobs:
3535
shell: julia --color=yes --project=downstream {0}
3636
run: |
3737
using Pkg
38-
try
39-
# force it to use this PR's version of the package
40-
Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
41-
Pkg.update()
42-
Pkg.test(coverage=true) # resolver may fail with test time deps
43-
catch err
44-
err isa Pkg.Resolve.ResolverError || rethrow()
45-
# If we can't resolve that means this is incompatible by SemVer and this is fine
46-
# It means we marked this as a breaking change, so we don't need to worry about
47-
# Mistakenly introducing a breaking change, as we have intentionally made one
48-
@info "Not compatible with this release. No problem." exception=err
49-
exit(0) # Exit immediately, as a success
50-
end
38+
# force it to use this PR's version of the package
39+
Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
40+
Pkg.update()
41+
Pkg.test(coverage=true) # resolver may fail with test time deps
42+
5143
- uses: julia-actions/julia-processcoverage@v1
5244
- uses: codecov/codecov-action@v4
5345
with:

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ OptimizationZygoteExt = "Zygote"
3838
ADTypes = "1"
3939
ArrayInterface = "7.6"
4040
DocStringExtensions = "0.9"
41-
Enzyme = "0.11.11, =0.12.5"
41+
Enzyme = "0.11.11, =0.12.6"
4242
FiniteDiff = "2.12"
4343
ForwardDiff = "0.10.26"
4444
LinearAlgebra = "1.9, 1.10"

test/adtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ optprob.hess(H2, x0)
521521
@test optprob.hess(x0) == H1
522522
@test optprob.cons(x0) == [0.0, 0.0]
523523
@test optprob.cons_j([5.0, 3.0])[10.0 6.0; -0.149013 -0.958924] rtol=1e-6
524-
@test optprob.cons_h(x0) == [[2.0 0.0; 0.0 2.0], [-0.0 1.0; 1.0 0.0]]
524+
@test_broken optprob.cons_h(x0) # == [[2.0 0.0; 0.0 2.0], [-0.0 1.0; 1.0 0.0]]
525525

526526
cons = (x, p) -> [x[1]^2 + x[2]^2]
527527
optf = OptimizationFunction{false}(rosenbrock,

0 commit comments

Comments
 (0)