Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returnTo function does not work #8

Open
xy74695321 opened this issue Dec 10, 2018 · 3 comments
Open

returnTo function does not work #8

xy74695321 opened this issue Dec 10, 2018 · 3 comments

Comments

@xy74695321
Copy link

hi,
I am able to use this plugin for keycloak to login mediawiki, But every time I log in, I log in to the home page. If there is a url with a path to access mediawiki, it will not automatically jump to the specified path, always jump to the home page.
Is the plugin not supported, or is my configuration incorrect?

@reiichi001
Copy link

reiichi001 commented May 13, 2019

mArticleID was always -1 for me, but I noticed that this variable should be replaced with the getArticleID() function instead.

Try adjusting the following on line 121:

<               if( !$title instanceof Title || 0 > $title->getArticleID() ) {
---
>               if( !$title instanceof Title || 0 > $title->mArticleID ) {

fheft added a commit to fheft/MW-OAuth2Client that referenced this issue May 20, 2019
* fix the check if the wiki title is valid by using the title object's
  getter method instead of directly accessing the member variable.
* closes Schine#8
@fheft
Copy link

fheft commented May 20, 2019

I stumbled across the same issue and created a pull-request: #9

@tobycatlin
Copy link

Thank you this fixed my issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants