test(events): align listing tests with private-event exclusion (#12071) - #12218
Open
ionfwsrijan wants to merge 1 commit into
Open
test(events): align listing tests with private-event exclusion (#12071)#12218ionfwsrijan wants to merge 1 commit into
ionfwsrijan wants to merge 1 commit into
Conversation
…SandeepVashishtha#12071) The public read path already excludes isPublic=false events (EventService filters Event::isPublic), but two controller tests still asserted the pre-fix behavior and would fail CI: - ListEventsTests.testGetAllEvents expected 2 events including a private one; it now expects only the public event and adds an explicit assertion that the private event is absent. - GetEventByIdTests.testGetPrivateEventById expected 200 + the private event body; it now expects 404, matching the documented behavior that private events are only visible to their organizer or an admin.
Contributor
|
@ionfwsrijan is attempting to deploy a commit to the sandeepvashishtha's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
type:bug
type:testing
quality:exceptional
github-actions
Bot
added
gssoc:approved
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Contributor
Author
|
@SandeepVashishtha Please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #12071: private events (
isPublic = false) are supposed to be invisible through the public event endpoints.EventService.getPublicEventById/getAllEventsalready filter them out, but two controller tests still asserted the pre-fix behavior and would fail CI:GetEventByIdTests.testGetPrivateEventByIdexpected200and the private event body;ListEventsTests.testGetAllEventsexpected the private event to be included inGET /api/events.Fix
Align the tests with the documented behavior and add explicit regression coverage:
testGetPrivateEventByIdnow expects404with the standard "Event not found" message.testGetAllEventsnow expects only the public event.testGetAllEventsExcludesPrivateEventsasserts the private event is absent from the listing.Files changed
Backend/src/test/java/com/sandeep/eventrabackend/controller/GetEventByIdTests.javaBackend/src/test/java/com/sandeep/eventrabackend/controller/ListEventsTests.javaTesting
EventService'sisPublic/CANCELLEDfiltering and the existing 404 error body contract.Closes #12071