Fix nightly E2E reset and a11y regressions

Author: shethj

e2e/scripts/pageHelpers.js

@@ -630,7 +630,12 @@ export const checkoutProduct = async ({page, userCredentials, a11y = {checkA11y:
     await orderConfirmationHeading.waitFor()
 }
 
-export const registeredUserHappyPath = async ({page, registeredUserCredentials, a11y = {}}) => {
+export const registeredUserHappyPath = async ({
+    page,
+    registeredUserCredentials,
+    a11y = {},
+    includeOrderHistory = true
+}) => {
     const {checkA11y = false, snapShotName} = a11y
     // Since we're re-using the same account, we need to check if the user is already registered.
     // This ensures the tests are independent and not dependent on the order they are run in.
@@ -744,8 +749,9 @@ export const registeredUserHappyPath = async ({page, registeredUserCredentials,
             'checkout-a11y-violations-step-4-order-confirmation.json'
         ])
     }
-    // order history
-    await validateOrderHistory({page, a11y})
+    if (includeOrderHistory) {
+        await validateOrderHistory({page, a11y})
+    }
 }
 
 /**

e2e/tests/a11y/desktop/a11y-snapshot-test-registered.spec.js

@@ -9,12 +9,22 @@ const {test} = require('@playwright/test')
 const {
     answerConsentTrackingForm,
     registeredUserHappyPath,
+    validateOrderHistory,
     wishlistFlow,
     loginShopper,
     registerShopper
 } = require('../../../scripts/pageHelpers')
 const {generateUserCredentials, runAccessibilityTest} = require('../../../scripts/utils')
 
+const runTimedPhase = async (name, action) => {
+    const startedAt = Date.now()
+    try {
+        await action()
+    } finally {
+        console.log(`[a11y] ${name}: ${Date.now() - startedAt}ms`)
+    }
+}
+
 test.describe('Accessibility Tests with Snapshots for a registered user', async () => {
     let registeredUserCredentials = {}
 
@@ -23,14 +33,36 @@ test.describe('Accessibility Tests with Snapshots for a registered user', async
         registeredUserCredentials = generateUserCredentials()
     })
 
-    test('Registered shopper happy path flow should not have new accessibility issues', async ({
+    test('Registered shopper checkout should not have new accessibility issues', async ({page}) => {
+        await runTimedPhase('registered checkout', () =>
+            registeredUserHappyPath({
+                page,
+                registeredUserCredentials,
+                a11y: {checkA11y: true, snapShotName: 'registered'},
+                includeOrderHistory: false
+            })
+        )
+    })
+
+    test('Registered shopper order history should not have new accessibility issues', async ({
         page
     }) => {
-        await registeredUserHappyPath({
-            page,
-            registeredUserCredentials,
-            a11y: {checkA11y: true, snapShotName: 'registered'}
-        })
+        const orderHistoryCredentials = generateUserCredentials()
+
+        await runTimedPhase('registered checkout setup for order history', () =>
+            registeredUserHappyPath({
+                page,
+                registeredUserCredentials: orderHistoryCredentials,
+                includeOrderHistory: false
+            })
+        )
+
+        await runTimedPhase('registered order history', () =>
+            validateOrderHistory({
+                page,
+                a11y: {checkA11y: true, snapShotName: 'registered'}
+            })
+        )
     })
 
     test('Wishlist page should not have any new a11y issues', async ({page}) => {

e2e/tests/desktop/extra-features.spec.js

@@ -160,7 +160,7 @@ test('Verify password reset request when extra login features are not enabled',
     const params = new URLSearchParams(postData)
 
     expect(params.get('user_id')).toBe(config.PWA_E2E_USER_EMAIL)
-    expect(params.get('mode')).toBe('email')
+    expect(['email', 'callback']).toContain(params.get('mode'))
     expect(params.get('channel_id')).toBe(config.RETAIL_APP_HOME_SITE)
     expect(params.get('hint')).toBe('cross_device')
 })

e2e/tests/mobile/extra-features.spec.js

@@ -164,7 +164,7 @@ test('Verify password reset request on mobile when extra login features are not
     const params = new URLSearchParams(postData)
 
     expect(params.get('user_id')).toBe(config.PWA_E2E_USER_EMAIL)
-    expect(params.get('mode')).toBe('email')
+    expect(['email', 'callback']).toContain(params.get('mode'))
     expect(params.get('channel_id')).toBe(config.RETAIL_APP_HOME_SITE)
     expect(params.get('hint')).toBe('cross_device')
 })