Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution to make the banner take full README width #23

Open
O1Anas opened this issue Jan 21, 2025 · 5 comments
Open

Solution to make the banner take full README width #23

O1Anas opened this issue Jan 21, 2025 · 5 comments

Comments

@O1Anas
Copy link
Contributor

O1Anas commented Jan 21, 2025

So in my README, when opening it with this link & the sidebar is closed I don't get a full width banner, like so:

Code

[![ReadMeSupportPalestine](https://raw.githubusercontent.com/Safouene1/support-palestine-banner/master/banner-support.svg)](https://github.com/Safouene1/support-palestine-banner/Markdown-pages/Support.md)

Preview

Image


@Safouene1 My solution is by using html, Just paste this html into your file instead of the perovious markdown text to get a full width banner

Code

<div align="center">
  <a href="https://github.com/Safouene1/support-palestine-banner/blob/master/Markdown-pages/Support.md">
    <img src="https://raw.githubusercontent.com/Safouene1/support-palestine-banner/master/banner-support.svg" alt="Support Palestine" style="width: 100%;">
  </a>
</div>

Preview

Image

Maybe @Safouene1 could include this option in this project's README/Documentation, thank you for this beautiful project and thank you for your support of the palestinian cause ❤.

@O1Anas
Copy link
Contributor Author

O1Anas commented Jan 21, 2025

Here's a one-liner version

Code

<div align="center"><a href="https://github.com/Safouene1/support-palestine-banner/blob/master/Markdown-pages/Support.md"><img src="https://raw.githubusercontent.com/Safouene1/support-palestine-banner/master/banner-support.svg" alt="Support Palestine" style="width: 100%;"></a></div>

Preview

Support Palestine

@Safouene1
Copy link
Owner

Thanks anas ! , could you please create a pull request with these changes

@O1Anas
Copy link
Contributor Author

O1Anas commented Feb 11, 2025

@Safouene1 I would love to, which area should I change exactly, the README file ? the documentation on the README ?

And should I change the markdown approach to the html one that I proposed or should I just leave the html approach as just an option ?

like this:

For the banner to take full width in the README's preview, You can use this HTML snippet instead:

<div align="center"><a href="https://github.com/Safouene1/support-palestine-banner/blob/master/Markdown-pages/Support.md"><img src="https://raw.githubusercontent.com/Safouene1/support-palestine-banner/master/banner-support.svg" alt="Support Palestine" style="width: 100%;"></a></div>

@Safouene1
Copy link
Owner

Yess please push it in a PR in a README , I would appreciate it

@O1Anas
Copy link
Contributor Author

O1Anas commented Feb 12, 2025

@Safouene1 , please review my humble pull request at #24

بارَكَ اللَّهُ فيكُم

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants