Fix deprecation errors caused by Yaml configuration

Author: nicwortel

app/config/config.yml

@@ -32,21 +32,20 @@ framework:
         save_path:   "%kernel.root_dir%/../var/sessions/%kernel.environment%"
     fragments:       ~
     http_method_override: true
-    assets: ~
 
 # Twig Configuration
 twig:
     debug:            "%kernel.debug%"
     strict_variables: "%kernel.debug%"
     globals:
-        application_title: %application_title%
-        my_groups_column_title_en: %my_groups_column_title_en%
-        my_groups_column_title_nl: %my_groups_column_title_nl%
-        org_groups_column_title_en: %org_groups_column_title_en%
-        org_groups_column_title_nl: %org_groups_column_title_nl%
-        all_groups_column_title_en: %all_groups_column_title_en%
-        all_groups_column_title_nl: %all_groups_column_title_nl%
-        documentation_url: %documentation_url%
+        application_title: '%application_title%'
+        my_groups_column_title_en: '%my_groups_column_title_en%'
+        my_groups_column_title_nl: '%my_groups_column_title_nl%'
+        org_groups_column_title_en: '%org_groups_column_title_en%'
+        org_groups_column_title_nl: '%org_groups_column_title_nl%'
+        all_groups_column_title_en: '%all_groups_column_title_en%'
+        all_groups_column_title_nl: '%all_groups_column_title_nl%'
+        documentation_url: '%documentation_url%'
 
 # Swiftmailer Configuration
 swiftmailer:
@@ -90,8 +89,8 @@ hslavich_simplesamlphp:
     authentication_attribute: urn:mace:dir:attribute-def:uid
 
 accelerator_cache:
-    host: %url%
-    web_dir: %kernel.root_dir%/../web
+    host: '%url%'
+    web_dir: '%kernel.root_dir%/../web'
 
 doctrine_cache:
     providers:

app/config/security.yml

@@ -7,7 +7,7 @@ security:
             memory:
                 users:
                     voot:
-                        password: %password_voot%
+                        password: '%password_voot%'
                         roles: 'ROLE_VOOT'
         simplesaml:
             id: app.user_provider

app/config/services.yml

@@ -5,41 +5,41 @@ services:
     app.ldap_read_client:
         class: AppBundle\Ldap\LdapClient
         arguments: ["%ldap_read_host%", "%ldap_read_port%", "%ldap_read_dn%", "%ldap_read_pass%"]
-        private: true
+        public: false
 
     app.ldap_write_client:
         class: AppBundle\Ldap\LdapClient
         arguments: ["%ldap_write_host%", "%ldap_write_port%", "%ldap_write_dn%", "%ldap_write_pass%"]
-        private: true
+        public: false
 
     app.ldap_fallback_clients:
         class: AppBundle\Ldap\LdapClients
-        private: true
+        public: false
 
     app.ldap_normalizer:
         class: AppBundle\Ldap\Normalizer
         arguments: ["%ldap.mapping%"]
-        private: true
+        public: false
 
     app.grouphub_ldap_client:
         class: AppBundle\Ldap\GrouphubClient
         arguments: ["@app.ldap_read_client", "@app.ldap_write_client", "@app.ldap_fallback_clients", "@app.ldap_normalizer", "%users_dn%", "%groups_dn%", "%grouphub_dn%", "%formal_dn%", "%adhoc_dn%", "%admin_groups_dn%", "%user_query%", "%group_query%", "%ldap.mapping%"]
-        private: true
+        public: false
 
     app.api_normalizer:
         class: AppBundle\Api\Normalizer
         arguments: ["%ldap.mapping%"]
-        private: true
+        public: false
 
     app.api_client:
         class: AppBundle\Api\ApiClient
         arguments: ["@guzzle.client.api_grouphub", "@app.api_normalizer"]
-        private: true
+        public: false
 
     app.queue:
         class: AppBundle\Service\QueueService
         arguments: ["@doctrine_cache.providers.cache"]
-        private: true
+        public: false
 
     app.sync:
         class: AppBundle\Service\SyncService