Skip to content

Commit b935e6b

Browse files
authored
Merge pull request #13782 from SORMAS-Foundation/bugfix-13517-survey-reset-filters-action
#13517 - Fixes Survey Reset filters action being wrong
2 parents bb5dfc4 + ee68f93 commit b935e6b

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

sormas-ui/src/main/java/de/symeda/sormas/ui/survey/SurveysView.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@ public SurveysView() {
3030
viewConfiguration = ViewModelProviders.of(getClass()).get(ViewConfiguration.class);
3131
criteria = ViewModelProviders.of(SurveysView.class).get(SurveyCriteria.class);
3232

33-
gridComponent = new SurveyGridComponent(criteria, viewConfiguration, () -> navigateTo(criteria, true), () -> navigateTo(null, true));
33+
gridComponent = new SurveyGridComponent(criteria, viewConfiguration, () -> navigateTo(criteria, true), () -> {
34+
ViewModelProviders.of(SurveysView.class).remove(SurveyCriteria.class);
35+
navigateTo(null, true);
36+
});
3437
addComponent(gridComponent);
3538

3639
if (UiUtil.permitted(UserRight.SURVEY_CREATE)) {
@@ -47,6 +50,9 @@ public void enter(ViewChangeListener.ViewChangeEvent event) {
4750
if (params.startsWith("?")) {
4851
params = params.substring(1);
4952
criteria.fromUrlParams(params);
53+
} else {
54+
criteria.setFreeText(null);
55+
criteria.setDisease(null);
5056
}
5157
setApplyingCriteria(true);
5258
gridComponent.updateFilterComponents(criteria);

sormas-ui/src/main/java/de/symeda/sormas/ui/utils/components/ApplyResetButtonsComponent.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ public class ApplyResetButtonsComponent extends HorizontalLayout {
1919
public ApplyResetButtonsComponent(String applyCaptionTag, String resetCaptionTag) {
2020
setSpacing(false);
2121

22-
resetButton = ButtonHelper.createButton(resetCaptionTag, null, FILTER_ITEM_STYLE);
23-
addComponent(resetButton);
24-
2522
applyButton = ButtonHelper.createButton(applyCaptionTag, null, FILTER_ITEM_STYLE);
2623
applyButton.setClickShortcut(ShortcutAction.KeyCode.ENTER);
2724
addComponent(applyButton);
25+
26+
resetButton = ButtonHelper.createButton(resetCaptionTag, null, FILTER_ITEM_STYLE);
27+
addComponent(resetButton);
2828
}
2929

3030
public void addApplyHandler(Button.ClickListener applyHandler) {

0 commit comments

Comments
 (0)