🐛 What's broken?
The tests/smoke.test.js file uses standard ES Module imports (import { ... } from ...), but relies on the CommonJS __dirname variable to resolve file paths on lines 12, 13, and 101. In a native Node.js ES Module environment, __dirname is undefined and will throw a ReferenceError. While Vitest injects a polyfill for this under the hood, relying on it in an ESM file violates Node.js best practices and can break standard Node execution or stricter linting rules.
📋 Steps to Reproduce
- Navigate to the repository file:
tests/smoke.test.js.
- Observe the ES Module
import syntax at the top of the file.
- Inspect lines 12 and 13 where
__dirname is used in the resolve() function.
✅ Expected Behavior
Path resolution in modern ES Modules should utilize import.meta.dirname (Node >= 20.11) or utilize fileURLToPath(import.meta.url) to construct the directory path safely.
❌ Actual Behavior
The file uses legacy CommonJS globals (__dirname) inside an ES Module.
🔗 Reproduction
Current Structure:
const coreDir = resolve(__dirname, '../core');
🐛 What's broken?
The
tests/smoke.test.jsfile uses standard ES Module imports (import { ... } from ...), but relies on the CommonJS__dirnamevariable to resolve file paths on lines 12, 13, and 101. In a native Node.js ES Module environment,__dirnameisundefinedand will throw aReferenceError. While Vitest injects a polyfill for this under the hood, relying on it in an ESM file violates Node.js best practices and can break standard Node execution or stricter linting rules.📋 Steps to Reproduce
tests/smoke.test.js.importsyntax at the top of the file.__dirnameis used in theresolve()function.✅ Expected Behavior
Path resolution in modern ES Modules should utilize
import.meta.dirname(Node >= 20.11) or utilizefileURLToPath(import.meta.url)to construct the directory path safely.❌ Actual Behavior
The file uses legacy CommonJS globals (
__dirname) inside an ES Module.🔗 Reproduction
Current Structure: