-
Notifications
You must be signed in to change notification settings - Fork 469
[BUG] Manual CSS concatenation in smoke.test.js lacks newline separators #2776
Copy link
Copy link
Closed
Labels
GSSoC-26Official GSSoC 2026 issueOfficial GSSoC 2026 issueacceptedContribution approved for integration into EaseMotion CSSContribution approved for integration into EaseMotion CSSanimationAnimation effects, hover interactions, motion ideas, transitionsAnimation effects, hover interactions, motion ideas, transitionsgood first issueGood for newcomersGood for newcomersgssoc:approvedApproved for GSSoC contributionsApproved for GSSoC contributionshelp wantedExtra attention neededExtra attention neededlevel:intermediateRequires moderate project understandingRequires moderate project understandingtype:featureNew functionality or enhancementNew functionality or enhancement
Metadata
Metadata
Assignees
Labels
GSSoC-26Official GSSoC 2026 issueOfficial GSSoC 2026 issueacceptedContribution approved for integration into EaseMotion CSSContribution approved for integration into EaseMotion CSSanimationAnimation effects, hover interactions, motion ideas, transitionsAnimation effects, hover interactions, motion ideas, transitionsgood first issueGood for newcomersGood for newcomersgssoc:approvedApproved for GSSoC contributionsApproved for GSSoC contributionshelp wantedExtra attention neededExtra attention neededlevel:intermediateRequires moderate project understandingRequires moderate project understandingtype:featureNew functionality or enhancementNew functionality or enhancement
🐛 What's broken?
In
tests/smoke.test.js, multiple CSS component files are manually concatenated into a singlecssstring using the+operator (lines 31-32). If any of the source CSS files end with a comment (e.g.,/* end of component */) or lack a trailing newline, they will merge directly into the first line of the next file. This can silently comment out rules or create invalid syntax that breaks the JSDOM CSS parser.📋 Steps to Reproduce
tests/smoke.test.js.beforeAllblock around lines 31-32.✅ Expected Behavior
The CSS file contents should be grouped into an array and joined with a newline character (
\n) to guarantee safe parsing between file boundaries.❌ Actual Behavior
Files are squashed together directly, risking syntax errors if source file formatting changes.
🔗 Reproduction
Current Structure: