Skip to content

False positives for check Message Easy To Find #588

Open
@NilsABCD

Description

@NilsABCD

Check Name
Message Easy To Find

Issue
The check produces a high number of false positives. Here are some examples where this can be observed:

  1. The check does also report findings for messages in text pools which makes no sense. Example code:

    data lv_etext type c length 100.
    lv_etext = 'No authority to replay'(e12).
    message lv_etext type 'I'.

  2. The check reports findings for messages that are thrown without the use of a message class (at least when you add a RAISING to the statement). Example code:

    data l_text type string.
    l_text = 'success'.
    message l_text type 'I' raising a.

  3. Even when the message class and message number are correctly defined with literals, the check raises a finding as soon as the addition 'WITH' or 'RAISING' or both of them are used. Example Code:

    message id '/AIF/BDC' type 'E' number '013' with iv_typename raising a.

I also found many cases where the statement was completely fine and the check still reported a finding, but I wasn't able to see a pattern when this happens and when not.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working correctly

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions