Skip to content

fix(errorDetector): classify HTTP 400 context overflow responses correctly #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hariom888 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(errorDetector): classify HTTP 400 context overflow responses correctly #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/router/errorDetector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ export class ErrorDetector {
case 403:
return "access_denied";
case 400:
// 400 can be context overflow or other issues
// Body may contain a specific error code (e.g. context_length_exceeded)
if (this.isApiError(error)) {
return this.classifyApiError(error);
}
return "unknown";
default:
return "unknown";
Expand Down Expand Up @@ -159,10 +162,16 @@ export class ErrorDetector {
const errorType = data.error?.type || data.type || "";
const errorCode = data.error?.code || data.code || "";

const lowerMessage = errorMessage.toLowerCase();

return (
errorType === "invalid_request_error" &&
(errorCode === "context_length_exceeded" ||
errorMessage.toLowerCase().includes("context"))
(
errorCode === "context_length_exceeded" ||
lowerMessage.includes("context") ||
lowerMessage.includes("too long") ||
lowerMessage.includes("maximum")
)
);
}

Expand Down