Merge pull request #83 from Juanperias/main

refactor: clippy errors

Author: SergioRibera

src/components/blog_content.rs

@@ -117,6 +117,8 @@ pub fn BlogContent(
 }
 
 #[component]
+#[must_use]
+#[allow(clippy::needless_pass_by_value, clippy::implicit_hasher)]
 pub fn ArticleHeader(
     #[prop()] title: String,
     #[prop()] github_user: Option<String>,
@@ -183,14 +185,14 @@ pub fn ArticleHeader(
                         })
                         .collect::<Vec<_>>()}
                     <div class="flex flex-row flex-wrap items-center gap-2">
-                        {if !social.is_empty() {
+                        {if social.is_empty() {
+                            view! { <></> }
+                        } else {
                             view! {
                                 <>
                                     <hr class="h-[0.875rem] w-px bg-gray-700 border-0" />
                                 </>
                             }
-                        } else {
-                            view! { <></> }
                         }}
                         {social
                             .iter()

src/components/button_link.rs

@@ -2,12 +2,13 @@ use leptos::{component, view, Children, IntoView};
 use std::collections::HashMap;
 
 #[component]
+#[must_use]
 pub fn ButtonLink(
     href: &'static str,
     #[prop(default = "primary")] color: &'static str,
     #[prop(default = "normal")] size: &'static str,
     #[prop(default = "drop")] shadow: &'static str,
-    #[prop(into, optional)] class: String,
+    #[prop(into, optional)] class: &'static str,
     children: Children,
 ) -> impl IntoView {
     let colors = HashMap::from([

src/components/card_article.rs

@@ -4,6 +4,7 @@ use crate::{
 };
 use leptos::{component, view, CollectView, IntoView};
 
+#[must_use]
 #[component]
 pub fn CardArticle(article: Article, is_home: bool) -> impl IntoView {
     let article_link = get_link(&article, is_home);
@@ -67,6 +68,7 @@ fn get_description(article: &Article) -> String {
     }
 }
 
+#[must_use]
 #[component]
 pub fn TagsList(tags: Option<Vec<String>>) -> impl IntoView {
     let tags = tags.unwrap_or_default();
@@ -79,6 +81,8 @@ pub fn TagsList(tags: Option<Vec<String>>) -> impl IntoView {
 }
 
 #[component]
+#[allow(clippy::needless_pass_by_value)]
+#[must_use]
 pub fn TagButton(tag: String) -> impl IntoView {
     let tag = tag.to_lowercase().replace(' ', "-");
 

src/components/esta_semana_en_rust/blog_content.rs

@@ -42,7 +42,7 @@ pub fn BlogContent(#[prop()] article: Article) -> impl IntoView {
                 </h1>
                 <div class="flex flex-col">
                     <div class="flex flex-row gap-4 text-sm items-center">
-                        {if !article.has_author() {
+                        {if article.has_author() {
                             view! {
                                 <>
                                     <h5>{article.author}</h5>
@@ -51,14 +51,14 @@ pub fn BlogContent(#[prop()] article: Article) -> impl IntoView {
                         } else {
                             view! { <></> }
                         }}
-                        {if !social.is_empty() {
+                        {if social.is_empty() {
+                            view! { <></> }
+                        } else {
                             view! {
                                 <>
                                     <hr class="h-[0.875rem] w-px bg-gray-700 border-0" />
                                 </>
                             }
-                        } else {
-                            view! { <></> }
                         }}
                         <div class="flex flex-row gap-2 items-center">
                             {social

src/components/esta_semana_en_rust/header.rs

@@ -2,6 +2,7 @@ use leptos::{component, create_signal, view, IntoView, SignalGet, SignalUpdate};
 
 use crate::components::button_link::ButtonLink;
 
+#[must_use]
 #[component]
 pub fn Header() -> impl IntoView {
     let (is_open, set_is_open) = create_signal(false);

src/components/esta_semana_en_rust/layout.rs

@@ -10,8 +10,9 @@ fn get_year() -> i32 {
     chrono::Utc::now().year()
 }
 
-#[component]
 // This is a common Layout component that will be used by all pages.
+#[component]
+#[must_use]
 pub fn Layout(
     #[prop(into, default=format!("Blog de Rust Lang en Español {}", get_year()))] title: String,
     #[prop(into, default="Somos una comunidad de Rust hispana, buscamos la promoción del lenguaje de programación Rust.".to_string())]

src/components/feature_articles.rs

@@ -14,6 +14,11 @@ use crate::{
 };
 use leptos_mdx::mdx::Mdx;
 
+/// # Panics
+/// If no article is found with the tag "esta semana en rust", the call to `unwrap()` will panic.
+/// If no article is found with the tag "anuncio de la comunidad", the second `unwrap()` will panic.
+/// If the "video" attribute is missing in any `YouTube` component, the `unwrap()` inside the closure will panic.
+/// If the value of the "video" attribute is None, the second `unwrap()` will also panic.
 pub async fn featured_articles() -> impl IntoView {
     let articles = ARTICLES.read().await.clone();
     let _invalid_tags = [
@@ -24,15 +29,13 @@ pub async fn featured_articles() -> impl IntoView {
     let esta_semana_en_rust = articles
         .clone()
         .into_iter()
-        .filter(|article| filter_article_by_tag(article.clone(), "esta semana en rust".to_string()))
+        .filter(|article| filter_article_by_tag(article, "esta semana en rust"))
         .take(1)
         .collect::<Vec<Article>>();
     let esta_semana_en_rust = esta_semana_en_rust.first().unwrap().to_owned();
     let anuncio_de_la_comunidad = articles
         .into_iter()
-        .filter(|article| {
-            filter_article_by_tag(article.clone(), "anuncio de la comunidad".to_string())
-        })
+        .filter(|article| filter_article_by_tag(article, "anuncio de la comunidad"))
         .take(1)
         .collect::<Vec<Article>>();
 
@@ -64,9 +67,9 @@ pub async fn featured_articles() -> impl IntoView {
 }
 
 #[must_use]
-pub fn filter_article_by_tag(article: Article, tag: String) -> bool {
+pub fn filter_article_by_tag(article: &Article, tag: &str) -> bool {
     if let Some(tags) = &article.tags {
-        tags.contains(&tag)
+        tags.contains(&tag.to_string())
     } else {
         false
     }

src/components/header.rs

@@ -4,6 +4,7 @@ use crate::components::button_link::ButtonLink;
 use crate::components::icons::logo_rust_page::LogoRustPageIcon;
 
 #[component]
+#[must_use]
 pub fn Header() -> impl IntoView {
     let (is_open, set_is_open) = create_signal(false);
 

src/components/icons/comments.rs

@@ -1,6 +1,7 @@
-use leptos::*;
+use leptos::{component, view, IntoView};
 
 #[component]
+#[must_use]
 pub fn CommentIcon(
     #[prop(default = 40)] size: u32,
     #[prop(into, default = "fill-black".to_string())] class: String,

src/components/icons/github.rs

@@ -1,6 +1,7 @@
 use leptos::{component, view, IntoView};
 
 #[component]
+#[must_use]
 pub fn GithubIcon(
     #[prop(default = 40)] size: u32,
     #[prop(into, default = "fill-black".to_string())] class: String,