Skip to content

Commit e3935e6

Browse files
authored
crypto_box: Revert "select x25519-dalek backend automatically (#55)" (#63)
This reverts commit a994fbf Automatic selection is not working correctly. See comments here: #55
1 parent c27e7e0 commit e3935e6

File tree

3 files changed

+12
-18
lines changed

3 files changed

+12
-18
lines changed

.github/workflows/crypto_box.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ jobs:
3636
toolchain: ${{ matrix.rust }}
3737
target: ${{ matrix.target }}
3838
override: true
39-
- run: cargo build --target ${{ matrix.target }} --release --no-default-features
40-
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features heapless
39+
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features u32_backend
40+
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features u32_backend,heapless
4141

4242
test:
4343
runs-on: ubuntu-latest
@@ -53,9 +53,9 @@ jobs:
5353
profile: minimal
5454
toolchain: ${{ matrix.rust }}
5555
override: true
56-
- run: cargo test --release --no-default-features
57-
- run: cargo test --release
58-
- run: cargo test --release --all-features
56+
- run: cargo test --release --features std
57+
- run: cargo test --release --features std,heapless
58+
- run: cargo test --release --features std,serde
5959

6060
cross:
6161
strategy:
@@ -78,4 +78,4 @@ jobs:
7878
target: ${{ matrix.target }}
7979
override: true
8080
- run: cargo install cross
81-
- run: cross test --release --target ${{ matrix.target }} --all-features
81+
- run: cross test --release --target ${{ matrix.target }} --features std,serde

crypto_box/Cargo.toml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,32 +22,29 @@ aead = { version = "0.5.1", default-features = false }
2222
chacha20 = "0.9"
2323
chacha20poly1305 = { version = "0.10.1", default-features = false, features = ["rand_core"] }
2424
salsa20 = "0.10"
25+
x25519-dalek = { version = "1", default-features = false }
2526
xsalsa20poly1305 = { version = "0.9", default-features = false, features = ["rand_core"] }
2627
zeroize = { version = "1", default-features = false }
2728

2829
# optional dependencies
2930
serdect = { version = "0.1", optional = true, default-features = false }
3031

31-
[target.'cfg(target_pointer_width = "32")'.dependencies]
32-
x25519-dalek = { version = "1", default-features = false, features = ["u32_backend"] }
33-
34-
[target.'cfg(target_pointer_width = "64")'.dependencies]
35-
x25519-dalek = { version = "1", default-features = false, features = ["u64_backend"] }
36-
3732
[dev-dependencies]
3833
bincode = "1"
3934
rand = "0.8"
4035
rmp-serde = "1"
4136

4237
[features]
43-
default = ["alloc", "getrandom"]
38+
default = ["alloc", "getrandom", "u64_backend"]
4439
std = ["aead/std"]
40+
serde = ["serdect"]
4541
alloc = ["aead/alloc"]
4642
getrandom = ["aead/getrandom", "rand_core"]
4743
heapless = ["aead/heapless"]
4844
rand_core = ["aead/rand_core"]
49-
serde = ["serdect"]
45+
u32_backend = ["x25519-dalek/u32_backend"]
46+
u64_backend = ["x25519-dalek/u64_backend"]
5047

5148
[package.metadata.docs.rs]
52-
all-features = true
49+
features = ["serde"]
5350
rustdoc-args = ["--cfg", "docsrs"]

crypto_box/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,6 @@
164164
//! [ECIES]: https://en.wikipedia.org/wiki/Integrated_Encryption_Scheme
165165
//! [`heapless::Vec`]: https://docs.rs/heapless/latest/heapless/struct.Vec.html
166166
167-
#[cfg(not(any(target_pointer_width = "32", target_pointer_width = "64")))]
168-
compile_error!("`crypto-box` requires either a 32-bit or 64-bit target");
169-
170167
pub use aead::{self, rand_core};
171168
pub use xsalsa20poly1305::Nonce;
172169

0 commit comments

Comments
 (0)