Skip to content

Commit f6fd208

Browse files
authored
Correct misunderstanding about bit direction for extra sizes (#89)
In a previous pull request #84 I added several sizes, but mistook the direction of the binary representation of the added values. Along with that one of the sizes was calculated incorrectly. (My apologies!) This corrects both of those errors, successfully tested using the downstream library. Also I checked (via script) all of the other binary representations and and they all match the assigned values. Co-authored-by: jmwample <[email protected]>
1 parent 3df563c commit f6fd208

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/sizes.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -819,15 +819,15 @@ mod extra_sizes {
819819
pub type U49856 = uint!(0 0 0 0 0 0 1 1 0 1 0 0 0 0 1 1);
820820

821821
// Kemeleon ML-KEM Encoding sizes
822-
pub type U749 = uint!(0 0 1 0 1 1 1 0 1 1 0 1);
823-
pub type U781 = uint!(0 0 1 1 0 0 0 0 1 1 0 1);
824-
pub type U877 = uint!(0 0 1 1 0 1 1 0 1 1 0 1);
825-
pub type U1124 = uint!(0 1 0 0 0 1 1 0 0 1 0 0);
826-
pub type U1156 = uint!(0 1 0 0 1 0 0 0 0 1 0 0);
827-
pub type U1252 = uint!(0 1 0 0 1 1 1 0 0 1 0 0);
828-
pub type U1498 = uint!(0 1 0 1 1 1 0 1 1 0 1 0);
829-
pub type U1530 = uint!(0 1 0 1 1 1 1 1 1 0 1 0);
830-
pub type U1626 = uint!(0 1 1 0 0 1 0 1 1 0 1 0);
822+
pub type U749 = uint!(1 0 1 1 0 1 1 1 0 1);
823+
pub type U781 = uint!(1 0 1 1 0 0 0 0 1 1);
824+
pub type U877 = uint!(1 0 1 1 0 1 1 0 1 1);
825+
pub type U1124 = uint!(0 0 1 0 0 1 1 0 0 0 1);
826+
pub type U1156 = uint!(0 0 1 0 0 0 0 1 0 0 1);
827+
pub type U1252 = uint!(0 0 1 0 0 1 1 1 0 0 1);
828+
pub type U1498 = uint!(0 1 0 1 1 0 1 1 1 0 1);
829+
pub type U1530 = uint!(0 1 0 1 1 1 1 1 1 0 1);
830+
pub type U1658 = uint!(0 1 0 1 1 1 1 0 0 1 1);
831831

832832
impl_array_sizes! {
833833
1040 => U1040,
@@ -1049,6 +1049,6 @@ mod extra_sizes {
10491049
1252 => U1252,
10501050
1498 => U1498,
10511051
1530 => U1530,
1052-
1626 => U1626,
1052+
1658 => U1658,
10531053
}
10541054
}

0 commit comments

Comments
 (0)