target enum: serde SpirvTargetEnv like a target string

Author: Firestar99

Cargo.lock

@@ -16,3 +16,6 @@ serde = ["dep:serde"]
 strum = { version = "0.26.3", features = ["derive"] }
 thiserror = "2.0.12"
 serde = { version = "1.0", features = ["derive"], optional = true }
+
+[dev-dependencies]
+serde_json = "1.0"

crates/rustc_codegen_spirv-target-specs/Cargo.toml

@@ -11,6 +11,8 @@ pub const TARGET_SPEC_DIR_PATH: &str = concat!(env!("CARGO_MANIFEST_DIR"), "/tar
 
 #[cfg(feature = "include_str")]
 mod include_str;
+#[cfg(feature = "serde")]
+mod serde;
 
 pub const SPIRV_ARCH: &str = "spirv";
 pub const SPIRV_VENDOR: &str = "unknown";
@@ -19,7 +21,6 @@ pub const SPIRV_TARGET_PREFIX: &str = "spirv-unknown-";
 /// All target envs rust-gpu supports. The corresponding target tripple is `spirv-unknown-ENV` with `ENV` replaced by any of the values below.
 #[allow(non_camel_case_types, clippy::upper_case_acronyms)]
 #[derive(Copy, Clone, Debug, Eq, PartialEq, Hash, EnumString, IntoStaticStr, EnumIter, Display)]
-#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub enum SpirvTargetEnv {
     #[strum(to_string = "opengl4.0")]
     OpenGL_4_0,

crates/rustc_codegen_spirv-target-specs/src/lib.rs

@@ -0,0 +1,35 @@
+use crate::SpirvTargetEnv;
+use serde::{Deserialize, Deserializer, Serialize, Serializer};
+
+impl Serialize for SpirvTargetEnv {
+    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
+    where
+        S: Serializer,
+    {
+        serializer.serialize_str(&self.target_triple())
+    }
+}
+
+impl<'de> Deserialize<'de> for SpirvTargetEnv {
+    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+    where
+        D: Deserializer<'de>,
+    {
+        let target = String::deserialize(deserializer)?;
+        Self::parse_triple(&target).map_err(|_e| serde::de::Error::unknown_variant(&target, &[]))
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use crate::SpirvTargetEnv;
+
+    #[test]
+    fn test_serde_roundtrip() {
+        for env in SpirvTargetEnv::iter() {
+            let json = serde_json::to_string(&env).unwrap();
+            let deserialize: SpirvTargetEnv = serde_json::from_str(&json).unwrap();
+            assert_eq!(env, deserialize);
+        }
+    }
+}