gccrs: fix ICE on missing pattern in while loop #4207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the changelog, please correctly designate the item being modified ( |
lucasly-ba
force-pushed
the
4162
branch
6 times, most recently
from
1370931 to
083af83
Compare
CohenArthur
reviewed
Oct 15, 2025
gcc/rust/parse/rust-parse-impl.h
Outdated
| = parse_match_arm_patterns (EQUAL); | ||
| // TODO: have to ensure that there is at least 1 pattern? | ||
| // ensure that there is at least 1 pattern | ||
| if (!predicate_patterns.size ()) |
There was a problem hiding this comment.
I think this is clearer:
Suggested change
| if (!predicate_patterns.size ()) | |
| if (predicate_patterns.empty()) |
Adds a proper check for missing patterns in while expressions. Fixes Rust-GCC#4162 gcc/rust/ChangeLog: * parse/rust-parse-impl.h(Parser<ManagedTokenSource>::parse_while_let_loop_expr): Add check for missing pattern. gcc/testsuite/ChangeLog: * rust/compile/issue-4162.rs: New test. Signed-off-by: Lucas Ly Ba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a proper check for missing patterns in while expressions.
Fixes #4162
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog:
* rust/compile/issue-4162.rs: New test.Signed-off-by: Lucas Ly Ba [email protected]