unrecognised token ‘|’ in grouped or tuple pattern after first pattern

[philberty]

Other example which should work as soon as we fix the above example:

enum NewTypeOrStruct {
    One(i32),
    Two{other: String, value: i32},
} 

fn foo((NewTypeOrStruct::One(foo) | NewTypeOrStruct::Two{other: _, value: foo}): NewTypeOrStruct) -> i32 {
    foo + 15i32
}

fn main() {
    foo(NewTypeOrStruct::One(15));
    foo(NewTypeOrStruct::Two {
        other: String::from("other"),
        value: 14
    });
}

Originally posted by @CohenArthur in #995 (comment)

[philberty]

@flip1995 @CohenArthur @SimplyTheOther or @bjorn3 is this a grouped pattern? https://doc.rust-lang.org/reference/patterns.html our parser doesn't handle the case of the '|' to fix this i think it is a grouped pattern but not sure how the AST looks like here in Rustc

[flip1995]

It's a grouped pattern. Function parameters are not normal Patterns, but PatternNoTopAlt. It can't be a TuplePattern in this case, because a TuplePattern either has to be .. or must include a ,.

In the AST it is a PatKind::Paren with a PatKind::Or inside

AST dump

pat: Pat {
    id: NodeId(25),
    kind: Paren(
        Pat {
            id: NodeId(26),
            kind: Or(
                [
                    Pat {
                        id: NodeId(27),
                        kind: TupleStruct(
                            None,
                            Path {
                                span: main.rs:8:9: 8:29 (#0),
                                segments: [
                                    PathSegment {
                                        ident: NewTypeOrStruct#0,
                                        id: NodeId(28),
                                        args: None,
                                    },
                                    PathSegment {
                                        ident: One#0,
                                        id: NodeId(29),
                                        args: None,
                                    },
                                ],
                                tokens: None,
                            },
                            [
                                Pat {
                                    id: NodeId(30),
                                    kind: Ident(
                                        ByValue(
                                            Not,
                                        ),
                                        foo#0,
                                        None,
                                    ),
                                    span: main.rs:8:30: 8:33 (#0),
                                    tokens: None,
                                },
                            ],
                        ),
                        span: main.rs:8:9: 8:34 (#0),
                        tokens: None,
                    },
                    Pat {
                        id: NodeId(31),
                        kind: Struct(
                            None,
                            Path {
                                span: main.rs:8:37: 8:57 (#0),
                                segments: [
                                    PathSegment {
                                        ident: NewTypeOrStruct#0,
                                        id: NodeId(32),
                                        args: None,
                                    },
                                    PathSegment {
                                        ident: Two#0,
                                        id: NodeId(33),
                                        args: None,
                                    },
                                ],
                                tokens: None,
                            },
                            [
                                PatField {
                                    ident: other#0,
                                    pat: Pat {
                                        id: NodeId(35),
                                        kind: Wild,
                                        span: main.rs:8:65: 8:66 (#0),
                                        tokens: None,
                                    },
                                    is_shorthand: false,
                                    attrs: ThinVec(
                                        None,
                                    ),
                                    id: NodeId(34),
                                    span: main.rs:8:58: 8:66 (#0),
                                    is_placeholder: false,
                                },
                                PatField {
                                    ident: value#0,
                                    pat: Pat {
                                        id: NodeId(37),
                                        kind: Ident(
                                            ByValue(
                                                Not,
                                            ),
                                            foo#0,
                                            None,
                                        ),
                                        span: main.rs:8:75: 8:78 (#0),
                                        tokens: None,
                                    },
                                    is_shorthand: false,
                                    attrs: ThinVec(
                                        None,
                                    ),
                                    id: NodeId(36),
                                    span: main.rs:8:68: 8:78 (#0),
                                    is_placeholder: false,
                                },
                            ],
                            false,
                        ),
                        span: main.rs:8:37: 8:79 (#0),
                        tokens: None,
                    },
                ],
            ),
            span: main.rs:8:9: 8:79 (#0),
            tokens: None,
        },
    ),
    span: main.rs:8:8: 8:80 (#0),
    tokens: None,
},

[P-E-P]

Godbolt link

[philberty]

looks like it now errors with:

crab1: internal compiler error: in function_set_parameters, at rust/rust-gcc.cc:2267
0x27c007c internal_error(char const*, ...)
	???:0
0xae015d fancy_abort(char const*, int, char const*)
	???:0
0xeea8cd Rust::Compile::HIRCompileBase::compile_function(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, Rust::HIR::SelfParam&, std::vector<Rust::HIR::FunctionParam, std::allocator<Rust::HIR::FunctionParam> >&, Rust::HIR::FunctionQualifiers const&, Rust::HIR::Visibility&, std::vector<Rust::AST::Attribute, std::allocator<Rust::AST::Attribute> >&, unsigned int, Rust::HIR::BlockExpr*, Rust::Resolver::CanonicalPath const&, Rust::TyTy::FnType*)
	???:0
0xebe278 Rust::Compile::CompileItem::visit(Rust::HIR::Function&)
	???:0
0xc3ba89 Rust::Compile::CompileCrate::go()
	???:0
0xc3bb08 Rust::Compile::CompileCrate::Compile(Rust::HIR::Crate&, Rust::Compile::Context*)
	???:0
0xc35ebe Rust::Session::compile_crate(char const*)
	???:0
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
Compiler returned: 1

for

enum NewTypeOrStruct {
    One(i32),
    Two{other: &str, value: i32},
} 

fn foo((NewTypeOrStruct::One(foo) | NewTypeOrStruct::Two{other: _, value: foo}): NewTypeOrStruct) -> i32 {
    foo + 15i32
}

fn main() {
    foo(NewTypeOrStruct::One(15));
    foo(NewTypeOrStruct::Two {
        other: "other",
        value: 14
    });
}