Merge #1172

1172: Resolve visibility paths  r=CohenArthur a=CohenArthur

This tackles the remaining issues in #1158. ~~It also contains the commit from #1168 so you should wait for bors to merge that before reviewing it :D~~ done 

The paths get resolved but their `NodeId`s are not used in the privacy visibility resolver yet.

Closes #1158 

Co-authored-by: Arthur Cohen <[email protected]>

Author: bors[bot]

gcc/rust/Make-lang.in

@@ -87,6 +87,7 @@ GRS_OBJS = \
     rust/rust-ast-lower-pattern.o \
     rust/rust-name-resolver.o \
     rust/rust-ast-resolve.o \
+    rust/rust-ast-resolve-base.o \
     rust/rust-ast-resolve-item.o \
     rust/rust-ast-resolve-pattern.o \
     rust/rust-ast-resolve-expr.o \

gcc/rust/ast/rust-ast.h

@@ -349,6 +349,7 @@ class SimplePathSegment : public PathSegment
 
   Location get_locus () const { return locus; }
   NodeId get_node_id () const { return node_id; }
+  const std::string &get_segment_name () const { return segment_name; }
 
   // TODO: visitor pattern?
 };
@@ -404,6 +405,11 @@ class SimplePath
       = {AST::SimplePathSegment (std::move (str), locus)};
     return SimplePath (std::move (single_segments));
   }
+
+  const std::vector<SimplePathSegment> &get_segments () const
+  {
+    return segments;
+  }
 };
 
 // path-to-string inverse comparison operator

gcc/rust/ast/rust-item.h

@@ -701,6 +701,7 @@ struct Visibility
 
   std::string as_string () const;
   const SimplePath &get_path () const { return in_path; }
+  SimplePath &get_path () { return in_path; }
 
 protected:
   // Clone function implementation - not currently virtual but may be if

gcc/rust/privacy/rust-visibility-resolver.cc

@@ -45,6 +45,17 @@ VisibilityResolver::go (HIR::Crate &crate)
     }
 }
 
+// FIXME: At this point in the pipeline, we should not be dealing with
+// `AST::SimplePath`s anymore! We need to be dealing with their "resolved
+// counterpart", so probably a NodeId/HirId/DefId.
+
+// static bool
+// resolve_module_path (std::vector<HIR::Module> &module_stack,
+// 		     const AST::SimplePath &restriction, DefId &id)
+// {
+//   return false;
+// }
+
 bool
 VisibilityResolver::resolve_visibility (const HIR::Visibility &visibility,
 					ModuleVisibility &to_resolve)