Fix flake resolution issues due to unpinned go version#500
Fix flake resolution issues due to unpinned go version#500ApprenticeofEnder wants to merge 3 commits into
Conversation
Signed-off-by: Robert Babaev <github@robertbabaev.tech>
Signed-off-by: Robert Babaev <github@robertbabaev.tech>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe flake adds a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@flake.nix`:
- Around line 26-31: The overlays list currently includes
gomod2nix.overlays.default separately from the custom overlay that pins go,
which means consumers importing overlays.default won't get the pinned Go; update
overlays.default (the exported overlay from gomod2nix) so it also sets go =
nixpkgs-go.packages.${system}.go or replace gomod2nix.overlays.default in the
overlays array with an overridden version (e.g., (final: prev:
(gomod2nix.overlays.default final prev) // { go =
nixpkgs-go.packages.${system}.go; })) so that both gomod2nix.overlays.default
and your custom overlay consistently apply the same pinned Go to prevent
downstream resolution errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 05b8911c-8334-4896-a8fa-1a4face2714a
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
flake.nix
|
I'm realizing that this may have been more easily solved by just bumping the patch number in |
Signed-off-by: Robert Babaev <github@robertbabaev.tech>
Why
What
References
Evidence
Recently, attempting to build the flake resulted in issues like this:
Git Bisect Result
Summary by CodeRabbit