Skip to content

Commit b0bc810

Browse files
BUG: Fix missing titles in roll parameter plots for fin sets (#934)
* BUG: Fix missing titles in roll parameter plots for fin sets Call set_title(None) on clf_delta and cld_omega after set_inputs/set_outputs in Fins.evaluate_roll_parameters() so the title is auto-generated from the updated axis names instead of remaining None. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * MNT: Update CHANGELOG for PR #934 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 0df092d commit b0bc810

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ Attention: The newest changes should be on top -->
6060
- BUG: energy_data plot not working for 3 dof sims [[#906](https://github.com/RocketPy-Team/RocketPy/issues/906)]
6161
- BUG: Fix CSV column header spacing in FlightDataExporter [#864](https://github.com/RocketPy-Team/RocketPy/issues/864)
6262
- BUG: Fix parallel Monte Carlo simulation showing incorrect iteration count [#806](https://github.com/RocketPy-Team/RocketPy/pull/806)
63+
- BUG: Fix missing titles in roll parameter plots for fin sets [#934](https://github.com/RocketPy-Team/RocketPy/pull/934)
6364
- BUG: Duplicate _controllers in Flight.TimeNodes.merge() [#931](https://github.com/RocketPy-Team/RocketPy/pull/931)
6465

6566
## [v1.11.0] - 2025-11-01

rocketpy/plots/aero_surface_plots.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ def roll(self):
164164
None
165165
"""
166166
print("Roll parameters:")
167-
# TODO: lacks a title in the plots
168167
self.aero_surface.roll_parameters[0]()
169168
self.aero_surface.roll_parameters[1]()
170169

rocketpy/rocket/aero_surface/fins/fins.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,7 @@ def evaluate_roll_parameters(self):
328328
) # Function of mach number
329329
clf_delta.set_inputs("Mach")
330330
clf_delta.set_outputs("Roll moment forcing coefficient derivative")
331+
clf_delta.set_title(None)
331332
cld_omega = (
332333
2
333334
* self.roll_damping_interference_factor
@@ -339,6 +340,7 @@ def evaluate_roll_parameters(self):
339340
) # Function of mach number
340341
cld_omega.set_inputs("Mach")
341342
cld_omega.set_outputs("Roll moment damping coefficient derivative")
343+
cld_omega.set_title(None)
342344
self.roll_parameters = [clf_delta, cld_omega, self.cant_angle_rad]
343345
return self.roll_parameters
344346

0 commit comments

Comments
 (0)