Update docker to the new adpater v2 #49
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the
rocketchat/hubot-rocketchat-boilerplate, I've update the Dockerfile to use only the necessary packages. Also, the.travis.ymlis now running theeslint, that is why the build is failing, and it pushes the docker image to docker hub on success. In order to make this work you need to configure at travis two env variablesDOCKER_PASSWORDandDOCKER_USERNAME.I've used the standard
.eslintrc.jsfile, probably we should update it based on the community feedback.Two things that I'm sending but I'm not sure:
pakage-lock.json, because otherwise the docker build was getting stuck on thenpm installstep. Since we have the docker version, I don't know if we have to maintain the lock in the repository.coffescriptdependency, assuming that we don't need it anymore