Skip to content

Commit 8192e7d

Browse files
committed
We can ignore less tests
1 parent 1a47e5f commit 8192e7d

File tree

1 file changed

+1
-49
lines changed

1 file changed

+1
-49
lines changed

test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php

Lines changed: 1 addition & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -133,19 +133,6 @@ static function (string $className): bool {
133133
return false;
134134
}
135135

136-
// https://github.com/JetBrains/phpstorm-stubs/pull/1781
137-
/** @var list<class-string> $missingClasses */
138-
$missingClasses = [
139-
'NoDiscard',
140-
'DelayedTargetValidation',
141-
];
142-
if (
143-
PHP_VERSION_ID >= 80500
144-
&& in_array($className, $missingClasses, true)
145-
) {
146-
return false;
147-
}
148-
149136
// Check only always enabled extensions
150137
return in_array($reflection->getExtensionName(), self::EXTENSIONS, true);
151138
},
@@ -203,10 +190,9 @@ private function assertSameClassAttributes(CoreReflectionClass $original, Reflec
203190
foreach ($original->getMethods() as $method) {
204191
$methodName = $original->getName() . '#' . $method->getName();
205192

206-
// https://github.com/JetBrains/phpstorm-stubs/pull/1781
193+
// Needs fixes in JetBrains/phpstorm-stubs
207194
if (
208195
in_array($methodName, [
209-
'Closure#getCurrent',
210196
'SplMinHeap#__serialize',
211197
'SplMinHeap#__unserialize',
212198
'SplMaxHeap#__serialize',
@@ -238,13 +224,6 @@ private function assertSameClassAttributes(CoreReflectionClass $original, Reflec
238224

239225
$constantName = $original->getName() . '::' . $originalConstant->getName();
240226

241-
// https://github.com/JetBrains/phpstorm-stubs/pull/1781
242-
if (
243-
in_array($constantName, ['Attribute::TARGET_CONSTANT'], true)
244-
) {
245-
continue;
246-
}
247-
248227
$stubbedConstant = $stubbed->getConstant($originalConstantName);
249228

250229
self::assertNotNull($stubbedConstant, $constantName);
@@ -342,20 +321,6 @@ public static function internalFunctionsProvider(): array
342321
static function (string $functionName): bool {
343322
$reflection = new CoreReflectionFunction($functionName);
344323

345-
// https://github.com/JetBrains/phpstorm-stubs/pull/1781
346-
if (
347-
PHP_VERSION_ID >= 80500
348-
&& in_array($functionName, [
349-
'array_first',
350-
'array_last',
351-
'clone',
352-
'get_error_handler',
353-
'get_exception_handler',
354-
], true)
355-
) {
356-
return false;
357-
}
358-
359324
// Check only always enabled extensions
360325
return in_array($reflection->getExtensionName(), self::EXTENSIONS, true);
361326
},
@@ -416,19 +381,6 @@ public static function internalConstantsProvider(): array
416381
}
417382

418383
foreach ($extensionConstants as $constantName => $constantValue) {
419-
// https://github.com/JetBrains/phpstorm-stubs/pull/1781
420-
if (
421-
PHP_VERSION_ID >= 80500
422-
&& in_array($constantName, [
423-
'IMAGETYPE_SVG',
424-
'IMAGETYPE_HEIF',
425-
'PHP_BUILD_DATE',
426-
'ZEND_VM_KIND',
427-
], true)
428-
) {
429-
continue;
430-
}
431-
432384
$provider[] = [$constantName, $constantValue, $extensionName];
433385
}
434386
}

0 commit comments

Comments
 (0)