Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot exclude transitive dependencies two layers deep #66

Open
AdamFrey opened this issue Aug 28, 2018 · 0 comments
Open

Cannot exclude transitive dependencies two layers deep #66

AdamFrey opened this issue Aug 28, 2018 · 0 comments

Comments

@AdamFrey
Copy link

AdamFrey commented Aug 28, 2018

I created a reproducible example repo, that has some more info in the README.

With a deps.edn that has exclusions for transitive dependency exclusions as below (ie clojurescript is not a direct dependency of uap-clj, but is a dependency of a dependency)

{:paths []
 :deps  {clj-http {:mvn/version "3.9.1" :exclusions [clj-tuple/clj-tuple ;; Transitive dependencies through potemkin
                                                     riddley/riddley]}
         uap-clj  {:mvn/version "1.3.3" :exclusions [com.taoensso/timbre ;; Transtive dependencies through russellwhitaker/immuconf
                                                     org.clojure/clojurescript]}}}

Running clj -Stree in the repo does not contain the excluded libraries, but lein deps :tree with lein-tools-deps set up does.

In my exploration of this issue I've found that the excluded transitive dependencies aren't present at the end of lein-tools-deps.plugin/resolve-dependencies-with-deps-edn, which seems to be correct behavior, but then they must get added sometime later by Leiningen internals.

@AdamFrey AdamFrey changed the title Cannot exclude transitve dependencies two layers deep Cannot exclude transitive dependencies two layers deep Aug 28, 2018
AdamFrey added a commit to AdamFrey/lein-tools-deps that referenced this issue Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant