Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient dependent tracking #5

Closed
Rexios80 opened this issue Nov 22, 2023 · 4 comments
Closed

More efficient dependent tracking #5

Rexios80 opened this issue Nov 22, 2023 · 4 comments

Comments

@Rexios80
Copy link
Owner

Rexios80 commented Nov 22, 2023

Don't track transitive dependents

Right now we're using metrics.scorecard.panaReport.allDependencies to get package dependencies, but that includes transitive dependencies. Should we instead fetch a pubspec for each package and use pubspec.allDependencies which does not include transitive?

Pros:

  • Less database storage
  • Less container memory usage when processing package data

Cons:

  • Requires an extra API call per package
  • Do developers care about transitive dependents?

Don't track dependents for packages from Google-owned publishers

These packages have an exceptionally high number of dependents, and a significant amount are added every scan. There are so many dependents for these packages that I can't imagine anyone would care if they are tracked or not.

Pros:

  • Less database storage

Cons:

  • Google engineers might want this data?
@Rexios80
Copy link
Owner Author

Rexios80 commented Nov 22, 2023

Only implement these changes if database storage or container resource usage become an issue

Will need to prune the database for this:

  • Remove all dependent data and history for Google-owned packages
  • Remove all dependent data and history for transitive dependents (the history part might be tricky)

@Rexios80 Rexios80 changed the title More efficient dependency tracking More efficient dependent tracking Nov 22, 2023
@Rexios80
Copy link
Owner Author

Also not tracking dependents for unlisted/discontinued packages at all would be a good idea

@Rexios80
Copy link
Owner Author

Rexios80 commented Dec 4, 2023

Transitive dependents are no longer tracked

@Rexios80
Copy link
Owner Author

Closing for now. WIll reopen if storage becomes an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant