Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Decompilation Segfault #4

Open
brightprogrammer opened this issue Feb 19, 2025 · 2 comments
Open

AI Decompilation Segfault #4

brightprogrammer opened this issue Feb 19, 2025 · 2 comments
Assignees
Labels
breaking bug Something isn't working

Comments

@brightprogrammer
Copy link
Collaborator

What seems like a regression bug is triggered after a few failed calls to AI decompilation feature. The number of calls it takes for the crash is not fixed. The issue is most likely introduced after the commit f438202.

Observed Behavior :

REd <fn_name> reports that the AI decompilation has failed and the user must retry again or recheck the function name. This failed decompilation can be validated from log file as well :

[TRACE] : [23:22:50] : [reai_request] : ENDPOINT : 'https://api.reveng.ai/v2/ai-decompilation/100162850'
[TRACE] : [23:22:50] : [reai_request] : METHOD : 'GET'
[TRACE] : [23:22:51] : [reai_request] : Response code : 200
[TRACE] : [23:22:51] : [reai_request] : RESPONSE.JSON : '{"status":true,"data":{"status":"uninitialised","decompilation":null,"function_mapping":null,"function_mapping_full":null},"message":null,"errors":null,"meta":{"pagination":null}}'
[ERROR] : [23:22:51] : [json_response_get_string] : Failed to get string value for key 'message'

[ERROR] : [23:22:51] : [rizin.display] : Failed to decompile "FUN_00001ea0"
Is this function from RevEngAI's analysis?
What's the output of REfl?

After a few more issues to the AI decompile command, the plugin segfaults and exits somewhere inside libcurl.

Expected Behavior :

The plugin successfuly reports decompilation failure or success without segfault.

@brightprogrammer brightprogrammer added breaking bug Something isn't working labels Feb 19, 2025
@brightprogrammer brightprogrammer self-assigned this Feb 19, 2025
@brightprogrammer
Copy link
Collaborator Author

378a105 Fixes this

@brightprogrammer
Copy link
Collaborator Author

There still exists the bug that plugin is somehow getting an error status when instead it should get an uninitialized status for decompilation poll endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant