From 7a6204285b9ac39466bd569a9a28fce479a0a1a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Boquizo=20S=C3=A1nchez?= Date: Thu, 13 Jun 2024 22:08:46 +0200 Subject: [PATCH 1/3] feat(getAchievementUnlocks): add new query params --- src/achievement/getAchievementUnlocks.test.ts | 2 ++ src/achievement/getAchievementUnlocks.ts | 2 +- src/achievement/models/achievement-unlock-entity.model.ts | 1 + .../models/get-achievement-unlocks-response.model.ts | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/achievement/getAchievementUnlocks.test.ts b/src/achievement/getAchievementUnlocks.test.ts index cbfe1fb..48baddc 100644 --- a/src/achievement/getAchievementUnlocks.test.ts +++ b/src/achievement/getAchievementUnlocks.test.ts @@ -45,6 +45,7 @@ describe("Function: getAchievementUnlocks", () => { { User: "Tiotroll2022", RAPoints: "348", + RASoftcorePoints: "363", DateAwarded: "2023-01-29 21:45:41", HardcoreMode: "0", }, @@ -91,6 +92,7 @@ describe("Function: getAchievementUnlocks", () => { { user: "Tiotroll2022", raPoints: 348, + raSoftcorePoints: 363, dateAwarded: "2023-01-29 21:45:41", hardcoreMode: false, }, diff --git a/src/achievement/getAchievementUnlocks.ts b/src/achievement/getAchievementUnlocks.ts index 6e76af2..27a73d0 100644 --- a/src/achievement/getAchievementUnlocks.ts +++ b/src/achievement/getAchievementUnlocks.ts @@ -75,7 +75,7 @@ export const getAchievementUnlocks = async ( const rawResponse = await call({ url }); return serializeProperties(rawResponse, { - shouldCastToNumbers: ["ID", "Points", "TrueRatio", "RAPoints"], + shouldCastToNumbers: ["ID", "Points", "TrueRatio", "RAPoints", "RASoftcorePoints"], shouldMapToBooleans: ["HardcoreMode"], }); }; diff --git a/src/achievement/models/achievement-unlock-entity.model.ts b/src/achievement/models/achievement-unlock-entity.model.ts index 9d6bcb5..78a7954 100644 --- a/src/achievement/models/achievement-unlock-entity.model.ts +++ b/src/achievement/models/achievement-unlock-entity.model.ts @@ -1,6 +1,7 @@ export interface AchievementUnlockEntity { user: string; raPoints: number; + raSoftcorePoints: number; dateAwarded: string; hardcoreMode: boolean; } diff --git a/src/achievement/models/get-achievement-unlocks-response.model.ts b/src/achievement/models/get-achievement-unlocks-response.model.ts index 57d034a..f92fc17 100644 --- a/src/achievement/models/get-achievement-unlocks-response.model.ts +++ b/src/achievement/models/get-achievement-unlocks-response.model.ts @@ -1,6 +1,7 @@ interface AchievementUnlocksResponseEntity { User: string; RAPoints: string; + RASoftcorePoints: string; DateAwarded: string; HardcoreMode: string; } From b5fb06058e9909342101a6a29a9c6527036a9f02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Boquizo=20S=C3=A1nchez?= Date: Thu, 13 Jun 2024 23:41:26 +0200 Subject: [PATCH 2/3] feat(getAchievementOfTheWeek): add new query params --- src/achievement/getAchievementUnlocks.ts | 8 +++++++- src/feed/getAchievementOfTheWeek.test.ts | 4 ++++ src/feed/getAchievementOfTheWeek.ts | 4 +++- src/feed/models/achievement-of-the-week.model.ts | 1 + .../models/get-achievement-of-the-week-response.model.ts | 1 + 5 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/achievement/getAchievementUnlocks.ts b/src/achievement/getAchievementUnlocks.ts index 27a73d0..34e0141 100644 --- a/src/achievement/getAchievementUnlocks.ts +++ b/src/achievement/getAchievementUnlocks.ts @@ -75,7 +75,13 @@ export const getAchievementUnlocks = async ( const rawResponse = await call({ url }); return serializeProperties(rawResponse, { - shouldCastToNumbers: ["ID", "Points", "TrueRatio", "RAPoints", "RASoftcorePoints"], + shouldCastToNumbers: [ + "ID", + "Points", + "TrueRatio", + "RAPoints", + "RASoftcorePoints", + ], shouldMapToBooleans: ["HardcoreMode"], }); }; diff --git a/src/feed/getAchievementOfTheWeek.test.ts b/src/feed/getAchievementOfTheWeek.test.ts index 128ae70..f0eac65 100644 --- a/src/feed/getAchievementOfTheWeek.test.ts +++ b/src/feed/getAchievementOfTheWeek.test.ts @@ -53,6 +53,7 @@ describe("Function: getAchievementOfTheWeek", () => { { User: "Tirbaba2", RAPoints: "72", + RASoftcorePoints: "72", DateAwarded: "2022-10-10 01:42:19", HardcoreMode: "1", }, @@ -91,6 +92,7 @@ describe("Function: getAchievementOfTheWeek", () => { { user: "Tirbaba2", raPoints: 72, + raSoftcorePoints: 72, dateAwarded: "2022-10-10 01:42:19", hardcoreMode: true, }, @@ -131,6 +133,7 @@ describe("Function: getAchievementOfTheWeek", () => { { User: "Tirbaba2", RAPoints: "72", + RaSoftcorePoints: "72", DateAwarded: "2022-10-10 01:42:19", HardcoreMode: "0", }, @@ -169,6 +172,7 @@ describe("Function: getAchievementOfTheWeek", () => { { user: "Tirbaba2", raPoints: 72, + raSoftcorePoints: 72, dateAwarded: "2022-10-10 01:42:19", hardcoreMode: false, }, diff --git a/src/feed/getAchievementOfTheWeek.ts b/src/feed/getAchievementOfTheWeek.ts index bfedbee..d22dba0 100644 --- a/src/feed/getAchievementOfTheWeek.ts +++ b/src/feed/getAchievementOfTheWeek.ts @@ -48,7 +48,8 @@ import type { * unlocks: [ * { * user: "Tirbaba2", - * rAPoints: "72", + * raPoints: "72", + * raSoftcorePoints: "72", * dateAwarded: "2022-10-10 01:42:19", * hardcoreMode: "1" * } @@ -75,6 +76,7 @@ export const getAchievementOfTheWeek = async ( "TrueRatio", "TotalPlayers", "RAPoints", + "RASoftcorePoints", "UnlocksCount", ], shouldMapToBooleans: ["HardcoreMode"], diff --git a/src/feed/models/achievement-of-the-week.model.ts b/src/feed/models/achievement-of-the-week.model.ts index 3fb2f49..2a5a4bf 100644 --- a/src/feed/models/achievement-of-the-week.model.ts +++ b/src/feed/models/achievement-of-the-week.model.ts @@ -21,6 +21,7 @@ export interface AchievementOfTheWeek { unlocks: Array<{ user: string; raPoints: number; + raSoftcorePoints: number; dateAwarded: string; hardcoreMode: boolean; }>; diff --git a/src/feed/models/get-achievement-of-the-week-response.model.ts b/src/feed/models/get-achievement-of-the-week-response.model.ts index 31759af..6942032 100644 --- a/src/feed/models/get-achievement-of-the-week-response.model.ts +++ b/src/feed/models/get-achievement-of-the-week-response.model.ts @@ -21,6 +21,7 @@ export interface GetAchievementOfTheWeekResponse { Unlocks: Array<{ User: string; RAPoints: string; + RASoftcorePoints: string; DateAwarded: string; HardcoreMode: string; }>; From d022573a9e6e686e2b5e35df9536dc4b2e319fef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Boquizo=20S=C3=A1nchez?= Date: Fri, 14 Jun 2024 00:18:56 +0200 Subject: [PATCH 3/3] fix(getAchievementOfTheWeek): minor mistake --- src/feed/getAchievementOfTheWeek.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/feed/getAchievementOfTheWeek.test.ts b/src/feed/getAchievementOfTheWeek.test.ts index f0eac65..97b4957 100644 --- a/src/feed/getAchievementOfTheWeek.test.ts +++ b/src/feed/getAchievementOfTheWeek.test.ts @@ -133,7 +133,7 @@ describe("Function: getAchievementOfTheWeek", () => { { User: "Tirbaba2", RAPoints: "72", - RaSoftcorePoints: "72", + RASoftcorePoints: "72", DateAwarded: "2022-10-10 01:42:19", HardcoreMode: "0", },