Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve apis.root correctly for external urls #1837

Merged
merged 5 commits into from
Jan 3, 2025
Merged

fix: resolve apis.root correctly for external urls #1837

merged 5 commits into from
Jan 3, 2025

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Jan 2, 2025 •
edited
Loading

What/Why/How?

Fixed the incorrect resolution of the apis' root when it is a URL.

The actual fix is using a correct helper: https://github.com/Redocly/redocly-cli/pull/1837/files#diff-b781401ffbc8754cb3f94aa3ae701de53a9bd3e93aec59c8a21e0b605fc2a8b7R95

Reference

Fixes #1836

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: cc30e29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr tatomyr force-pushed the fix/resolve-urls-correctly branch from 65e24b0 to 704ee33 Compare January 2, 2025 15:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 984.6 ± 15.5 957.8 1009.5 1.00 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 981.7 ± 30.0 952.6 1042.9 1.00

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 78.61% 5046/6419
🟡 Branches 67.24% 2055/3056
🟡 Functions 73.13% 833/1139
🟡 Lines 78.9% 4760/6033
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡
... / miscellaneous.ts
 68.4% 57.38% 72.22% 68.16%
🟢
... / bundle.ts
 89.8% 76% 100% 89.8%
🟢
... / lint.ts
 83.61% 57.89% 66.67% 83.61%

Test suite run success

833 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from cc30e29

@tatomyr tatomyr marked this pull request as ready for review January 2, 2025 16:47
@tatomyr tatomyr requested review from a team as code owners January 2, 2025 16:47
@tatomyr tatomyr requested a review from RomanHotsiy January 2, 2025 16:47
@Marshevskyy Marshevskyy merged commit ef2f412 into main Jan 3, 2025
42 checks passed
@Marshevskyy Marshevskyy deleted the fix/resolve-urls-correctly branch January 3, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLekawa JLekawa JLekawa approved these changes

@RomanHotsiy RomanHotsiy RomanHotsiy approved these changes

Assignees
No one assigned
Labels
deploy_s3_sandbox
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

root attribute in config file no longer accept http:// URL since 1.26.1
4 participants
@tatomyr @RomanHotsiy @JLekawa @Marshevskyy