add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP, ARRINDEX, ARRTRIM, OBJKEYS (#33)

1. json_del: backward fix on json_del to support full key delete
2. json_set: error on creation of key with path!=root
3. mark commands as "write"  and open keys with open_key() on readonly
4. set_value: add support for root set and returns error when path not found
5. get_doc: return error on wrong path
6. redisjson.rs: turn num_op into a generic value_op
7. lib.rs: add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP
8. Add support for JSON.ARRINDEX
9. Add support for JSON.ARRTRIM & fix ARRINSERT to accept negative index
10. Add support for JSON.OBJKEYS
11. add special handling for path=$ (root), can't call replace_with
12. Return poped value on arrpop and fix error handle on replace with wrong path
13. fix path backward on ARRPOP

* Fix commands for backward:
1. STRAPPEND & ARRAPPNED return the len after update
2. MGET returns nil when path not found for a key

* json.arrinsert inserts items in original order (and not reversed)

* Verify we have no superfluous command args

Author: gkorland

.circleci/config.yml

@@ -3,7 +3,7 @@ version: 2
 jobs:
   build:
     docker:
-      - image: circleci/rust
+      - image: circleci/rust:buster
 
     steps:
       - checkout
@@ -12,7 +12,10 @@ jobs:
 
       - run:
           name: Install prerequisite
-          command: sudo apt-get install -y clang
+          command: |
+             sudo apt-get install -y software-properties-common
+             sudo add-apt-repository -y ppa:chris-lea/redis-server
+             sudo apt-get install -y clang python-pip redis-server
 
       - run:
           name: Version information
@@ -45,9 +48,11 @@ jobs:
       #            rustup run stable rustc --version --verbose
       #            rustup run stable cargo --version --verbose
       #            rustup run stable cargo build
-      #      - run:
-      #          name: Test
-      #          command: rustup run stable cargo test
+      - run:
+          name: Test
+          command: |
+             pip install -r ./test/pytest/requirements.txt
+             python ./test/pytest/test.py
       #      - run:
       #          name: Upload Coverage
       #          command: ./scripts/codecov.sh
@@ -57,6 +62,6 @@ jobs:
             - "~/.cargo"
             - "./target"
 
-      - run:
-          name: Run all tests
-          command: cargo test --all
+#      - run:
+#          name: Run all tests
+#          command: cargo test --all

.gitmodules

@@ -1,3 +1,4 @@
 [submodule "redismodule-rs"]
-	path = redismodule-rs
-	url = https://github.com/RedisLabsModules/redismodule-rs
+        path = redismodule-rs
+        url = https://github.com/RedisLabsModules/redismodule-rs
+        branch = cryptorelay-picks  

redismodule-rs

@@ -0,0 +1,33 @@
+pub(crate) trait Index {
+    fn normalize(self, len: i64) -> usize;
+}
+
+impl Index for i64 {
+    fn normalize(self, len: i64) -> usize {
+        let index = if self < 0 {
+            len - len.min(-self)
+        } else {
+            (len - 1).min(self)
+        };
+        index as usize
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_index() {
+        // [0,1,2,3,4]
+        assert_eq!((-6).normalize(5), 0);
+        assert_eq!((-5).normalize(5), 0);
+        assert_eq!((-2).normalize(5), 3);
+        assert_eq!((-1).normalize(5), 4);
+        assert_eq!(0.normalize(5), 0);
+        assert_eq!(1.normalize(5), 1);
+        assert_eq!(4.normalize(5), 4);
+        assert_eq!(5.normalize(5), 4);
+        assert_eq!(6.normalize(5), 4);
+    }
+}